Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checks for process.version.node #426

Merged
merged 1 commit into from
Jun 5, 2020
Merged

fix checks for process.version.node #426

merged 1 commit into from
Jun 5, 2020

Conversation

FredKSchott
Copy link
Owner

No description provided.

@josephg
Copy link

josephg commented Jun 5, 2020

This still isn't fixing the issue for me. I've made a proof of concept showing the issue I'm running into here. The problem seems to require the wasm files to be in a module that gets imported, so in that demo I've made a quick and dirty submod/ directory with an emscripten module that gets copied into node_modules on install.

I still get errors when I try and run it, with or without this branch:

image

@FredKSchott
Copy link
Owner Author

FredKSchott commented Jun 5, 2020

Okay, I believe that's that's a separate issue. Have you tried the resolution that it's giving you to add rollup-plugin-node-polyfills to {installOptions: {rollup: { plugins: [...] }} in your config file?

@FredKSchott FredKSchott merged commit 2a18308 into master Jun 5, 2020
@FredKSchott FredKSchott deleted the emscripten-fix branch June 5, 2020 16:17
@FredKSchott
Copy link
Owner Author

Let's follow up back in https://www.pika.dev/npm/snowpack/discuss/302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants