Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snowpack docs for homepage config #511

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Fix Snowpack docs for homepage config #511

merged 1 commit into from
Jun 18, 2020

Conversation

drwpow
Copy link
Collaborator

@drwpow drwpow commented Jun 18, 2020

Fixes docs bug raised in https://www.pika.dev/npm/snowpack/discuss/375. We accidentally show "homepage" as a Snowpack config (which was renamed to buildOptions.baseUrl), not a package.json config. This removes it.

@drwpow drwpow requested a review from a team as a code owner June 18, 2020 16:03
@vercel
Copy link

vercel bot commented Jun 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/b7px4r5zv
✅ Preview: https://snowpack-git-drwpow-docs-fix.pikapkg.vercel.app

@drwpow drwpow requested a review from FredKSchott June 18, 2020 17:10
@drwpow drwpow changed the title Remove homepage from Snowpack config Fix Snowpack docs for homepage config Jun 18, 2020
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwpow drwpow merged commit df3a7e4 into master Jun 18, 2020
@drwpow drwpow deleted the drwpow/docs-fix branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants