Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose install function #518

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Conversation

jlkiri
Copy link
Contributor

@jlkiri jlkiri commented Jun 19, 2020

In this PR I simply expose the install function without any modifications.

Related issues: #312

@jlkiri jlkiri requested a review from a team as a code owner June 19, 2020 15:35
@vercel
Copy link

vercel bot commented Jun 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/lsvrf6au9
✅ Preview: https://snowpack-git-fork-jlkiri-expose-install-api.pikapkg.vercel.app

@jlkiri
Copy link
Contributor Author

jlkiri commented Jun 19, 2020

I'm not sure if i need to add https://www.npmjs.com/package/@pika/plugin-build-types, because @pika/plugin-ts-standard-pkg is already used and the docs of plugin-build-types say:

Note: This plugin is not needed if you are already writing TypeScript and using the ts-standard-pkg plugin.

Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this as a starting point, but with an "unstable" prefix:

export {install as unstable_installCommand} from './commands/install';

Even though we won't document this on snowpack.dev, we still want to make sure that someone who does find it knows that it's not officially supported and could change across even patch versions, until we get further along in the work outlined in #312 and feel comfortable maintaining via semver)

@jlkiri If you can make that change, I'll merge.

@FredKSchott FredKSchott self-requested a review June 19, 2020 20:33
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed above

Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We actually might need to prioritize a true install JS API sooner rather than later for #475

@FredKSchott FredKSchott merged commit 22b4362 into FredKSchott:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants