Fix transform() bug #685
Merged
Fix transform() bug #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/9guxci1cv |
drwpow
commented
Jul 31, 2020
| @@ -108,9 +108,9 @@ async function runPipelineTransformStep( | |||
| urlPath: `./${path.basename(rootFileName + destExt)}`, | |||
| }); | |||
| if (typeof result === 'string') { | |||
| output[srcExt] = result; | |||
| output[destExt] = result; | |||
There was a problem hiding this comment.
This is a bit difficult to follow, so here’s an example: .vue files will generate .js and .css. This transform function then runs twice for .js and then for .css.
What was happening was:
output['.vue'] = [js transform]output['.vue'] = [css transform]
The original srcExt (.vue) was receiving all the transformations, then being blown away. This PR fixes that, and actually keeps the transformations.
FredKSchott
approved these changes
Jul 31, 2020
|
nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Found the bug that https://www.pika.dev/npm/snowpack/discuss/510 was referring to 😅. I encountered this trying to run
.vuefiles through a post-transformation in #684.This should actually be merged & published soon; without it
transform()plugins actually don’t work at all.Testing
This is difficult to test. I encountered this by running the #684 PostCSS plugin locally.