Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import resolver issue on Windows #731

Merged
merged 1 commit into from
Aug 4, 2020
Merged

fix import resolver issue on Windows #731

merged 1 commit into from
Aug 4, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

Testing

Should be covered by existing tests.

@FredKSchott FredKSchott requested a review from a team as a code owner August 4, 2020 07:10
@vercel
Copy link

vercel bot commented Aug 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/3zcwxzm0w
✅ Preview: https://snowpack-git-fix-import-resolver.pikapkg.vercel.app

@FredKSchott FredKSchott mentioned this pull request Aug 4, 2020
Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! All tests passing.

@drwpow drwpow merged commit 7cb9de8 into master Aug 4, 2020
@drwpow drwpow deleted the fix-import-resolver branch August 4, 2020 17:29
@francislavoie
Copy link
Contributor

francislavoie commented Aug 6, 2020

I may be wrong, but I think this caused a regression to the fix in #698

With 2.7.4 I get:

import React from "web_modules/react.js";

With 2.7.5 (with the fix from #698) I get:

import React from "./web_modules/react.js";

But with 2.7.6 I get:

import React from "web_modules/react.js";

@drwpow
Copy link
Collaborator

drwpow commented Aug 6, 2020

I may be wrong, but I think this caused a regression to the fix in #698

Bah! You’re right. Adding a test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backward slash in webmodules path on Windows
3 participants