Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial request responses #794

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Aug 12, 2020

Changes

Allows the dev server to handle partial (range) requests. Fixes #755

I'm currently unsure how this may affect other requests. I will be looking into a bit more but wanted to get this out here for visibility.

image

@stramel stramel self-assigned this Aug 12, 2020
@vercel
Copy link

vercel bot commented Aug 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/i4pir6s3b
✅ Preview: https://snowpack-git-fork-stramel-ms-fix-range-requests.pikapkg.vercel.app

Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, since this is locked to only affect requests that send a "RANGE" header, I feel fairly confident that this won't affect other existing requests. Do you have a demo app that you're using to test locally, with an mp4 or some other video file?

packages/snowpack/src/commands/dev.ts Outdated Show resolved Hide resolved
packages/snowpack/src/commands/dev.ts Outdated Show resolved Hide resolved
@stramel stramel marked this pull request as ready for review August 26, 2020 01:31
@stramel stramel requested a review from a team as a code owner August 26, 2020 01:31
@stramel
Copy link
Contributor Author

stramel commented Aug 26, 2020

This also fixes some issues with etags and sending binary files

Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredKSchott FredKSchott merged commit 4b0113f into FredKSchott:master Aug 26, 2020
@stramel stramel deleted the ms/fix-range-requests branch August 26, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants