fix alias match function #890
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/r5pugzmcl |
MoonBall
force-pushed
the
fix/alias-sequentially
branch
from
2becadc
to
ed3d3fc
Compare
MoonBall
force-pushed
the
fix/alias-sequentially
branch
from
ed3d3fc
to
7214e97
Compare
MoonBall
force-pushed
the
fix/alias-sequentially
branch
from
7214e97
to
6c7d507
Compare
MoonBall
force-pushed
the
fix/alias-sequentially
branch
from
6c7d507
to
461d94f
Compare
| @@ -261,6 +261,8 @@ export function findMatchingAliasEntry( | |||
| ): {from: string; to: string; type: 'package' | 'path'} | undefined { | |||
| // Only match bare module specifiers. relative and absolute imports should not match | |||
| if ( | |||
| spec === '.' || | |||
| spec === '..' || | |||
There was a problem hiding this comment.
ha! is this supported in the browser? I'm not sure if I've ever used this myself, but I guess this is a valid path?
There was a problem hiding this comment.
There is a case that is using import * from '.'; in utils/a.js to import some other function.
| return undefined; | ||
|
|
||
| for (const [from, to] of Object.entries(config.alias)) { | ||
| let foundType: 'package' | 'path' | '' = ''; |
There was a problem hiding this comment.
/cc @drwpow '' = '' as a type seems fishy, I would have liked to have cleaned this up a bit before merging. Will create a quick PR to follow up.
Changes
alias: { "@": "." }andalias: { "@": ".." }Testing
Test added