Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no web_modules proxy file #906

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

MoonBall
Copy link
Contributor

@MoonBall MoonBall commented Aug 25, 2020

Changes

fix #902.
The allFiles is always empty because of the commit

Testing

adding test later

@MoonBall MoonBall requested a review from a team as a code owner August 25, 2020 04:02
@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/d62ek9k5a
✅ Preview: https://snowpack-git-fork-moonball-fix-webmodules-proxy.pikapkg.vercel.app

@FredKSchott
Copy link
Owner

FredKSchott commented Aug 25, 2020

Ah, of course! If we exclude the build directory, then it would always be empty. 🤦

package-bootstrap test covers this once we update the snapshot. I'll merge and then update.

Thanks for your contribution!

@FredKSchott FredKSchott merged commit 9bbba4d into FredKSchott:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: imported CSS file not being emitted as <name>.css.proxy.js
2 participants