Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger to log all arguments passed #951

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

FredKSchott
Copy link
Owner

Changes

  • Right now, if I do console.log('a', 'b', 'c'), we only log "a" during development.
  • This now matches the logged string to Node's behavior, which is actually to use util.format behind the scenes

Testing

  • No dev tests

@FredKSchott FredKSchott requested a review from a team as a code owner August 28, 2020 01:56
@vercel
Copy link

vercel bot commented Aug 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/2dbdmtuok
✅ Preview: https://snowpack-git-small-logger-fix.pikapkg.vercel.app

@FredKSchott FredKSchott merged commit 2905af5 into master Aug 28, 2020
@FredKSchott FredKSchott deleted the small-logger-fix branch August 28, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants