fix(snowpack): exit process after success #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the primary node process is exited, which cleans up any associated child processes spawned by it. Without this, `build` (specifically) can hang indefinitely even though it was successful and Snowpack knows it's complete.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/d6j4mmc10 |
lukeed
commented
Aug 28, 2020
| @@ -105,15 +105,15 @@ export async function cli(args: string[]) { | |||
|
|
|||
| if (cmd === 'build') { | |||
| await buildCommand(commandOptions); | |||
| return; | |||
| return process.exit(0); | |||
There was a problem hiding this comment.
This is the one that matters (and has likelihood of spawning subprocesses) -- the others were added for consistency.
|
Curious: what specifically was causing it to hang for you? |
FredKSchott
approved these changes
Aug 28, 2020
|
I can go back and find out more granularly, but i noticed it after attaching |
|
interesting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that the primary node process is exited, which cleans up any associated child processes spawned by it. Without this,
build(specifically) can hang indefinitely even though it was successful and Snowpack knows it's complete.Screenshots
There's some additional logging in here -- remnants of my hunt to make sure it wasn't a fault of Snowpack elsewhere. For example, the
stoppingis at the cleanup stage of the esbuild plugin.Before
After
Testing
Did not add tests since nothing should be altered by default. The
returnalready implied a0exit code, preventing the finalprocess.exit(1)from running. By addingprocess.exit(0)we're basically just redefining the defaults.