Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tree shaking package when imports include file extensions #972

Merged
merged 1 commit into from
Aug 31, 2020
Merged

fix: tree shaking package when imports include file extensions #972

merged 1 commit into from
Aug 31, 2020

Conversation

MoonBall
Copy link
Contributor

Changes

fix #969

Testing

test added.

@MoonBall MoonBall requested a review from a team as a code owner August 31, 2020 13:04
@vercel vercel bot temporarily deployed to Preview August 31, 2020 13:04 Inactive
@vercel
Copy link

vercel bot commented Aug 31, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/68e1kzhrm
✅ Preview: Canceled

drwpow
drwpow approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Also, thanks for the cleanup!

@drwpow drwpow merged commit d484739 into FredKSchott:master Aug 31, 2020
@FredKSchott
Copy link
Owner

smart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree-shaking package imports that include file extensions
3 participants
@MoonBall @FredKSchott @drwpow