docs(CONTRIBUTE): add note about warnings when running yarn build. Add sections
#979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/frx3nqhgw [update for 3603ca7 canceled] |
gr2m
commented
Sep 2, 2020
| ``` | ||
|
|
||
| ### Discussion | ||
| ## Discussion | ||
|
|
||
| [Join the Pika Discord](https://discord.gg/rS8SnRk) |
There was a problem hiding this comment.
It's out of scope of this pull request, but I wonder if we should add a link to the repository's discussion forum here?
There was a problem hiding this comment.
yea! We still see more people hitting our issues page than our "discussions page" by almost 2x
FredKSchott
reviewed
Sep 2, 2020
Co-authored-by: Fred K. Schott <fkschott@gmail.com>
…Pattern` /cc @FredKSchott follow up to #979
gr2m
force-pushed
the
958/contributing/setup-friction
branch
from
427996c
to
982ff14
Compare
FredKSchott
approved these changes
Sep 4, 2020
| ``` | ||
|
|
||
| ### Discussion | ||
| ## Discussion | ||
|
|
||
| [Join the Pika Discord](https://discord.gg/rS8SnRk) |
There was a problem hiding this comment.
yea! We still see more people hitting our issues page than our "discussions page" by almost 2x
|
@gr2m feel free to merge this when you’re ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #958 (comment)
Changes
yarn buildTesting
n/a