Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add manifest to webpack plugin #983

Merged
merged 2 commits into from
Sep 3, 2020
Merged

add manifest to webpack plugin #983

merged 2 commits into from
Sep 3, 2020

Conversation

MoonBall
Copy link
Contributor

@MoonBall MoonBall commented Sep 2, 2020

Changes

solve the issue #955.
I test it in a new @snowpack/app-template-react project by using npm link. And then the generating manifest is as below.

{
  "commons.js": "/js/commons.95f23ff96f7c2c05e3da.js",
  "index.js": "/js/index.c6bd3571682a9fa98854.js",
  "lib-0db4f475.js": "/js/lib-0db4f475.170551a15456bfb13a44.js",
  "webpack-runtime.js": "/js/webpack-runtime.164e3a9d86a338adba9d.js",
  "assets/logo-d264c5adf9650c78ea3f951b10fb965a.svg": "/assets/logo-d264c5adf9650c78ea3f951b10fb965a.svg",
  "js/commons.95f23ff96f7c2c05e3da.js.LICENSE.txt": "/js/commons.95f23ff96f7c2c05e3da.js.LICENSE.txt"
}

Testing

@MoonBall MoonBall requested a review from a team as a code owner September 2, 2020 07:52
@vercel vercel bot temporarily deployed to Preview September 2, 2020 07:52 Inactive
@vercel
Copy link

vercel bot commented Sep 2, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/r1186dnlb
✅ Preview: Canceled

[update for e97b99c canceled]

@MoonBall MoonBall force-pushed the feat/add-manifest-to-webpack-plugin branch from ebe56e0 to eedd2cc Compare September 2, 2020 07:54
@vercel vercel bot temporarily deployed to Preview September 2, 2020 07:54 Inactive
@vercel vercel bot temporarily deployed to Preview September 3, 2020 01:22 Inactive
FredKSchott
FredKSchott approved these changes Sep 3, 2020
View reviewed changes
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for remembering to add docs as well 👍 👍

@FredKSchott FredKSchott merged commit 2be375a into FredKSchott:master Sep 3, 2020
@FredKSchott FredKSchott mentioned this pull request Sep 3, 2020
Closed
janajri
janajri reviewed Sep 8, 2020
View reviewed changes
plugins/plugin-webpack/plugin.js
args.manifest === true ? './asset-manifest.json' : `${args.manifest}`;

const manifest =
typeof args.manifest === string
Copy link
Contributor

@janajri janajri Sep 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredKSchott snowpack v2.10.2 may have broken on string vs 'string'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bah, thank you! my master was out of date when I released, and didn't pull in the fix for this in #1005 .

Just re-released with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

@janajri janajri janajri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MoonBall @FredKSchott @janajri