Decrease Minimum "Min Command Delay" to 1ms #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent reports on EroScripts (ref) show that users have been having issues with scripts that aren't slow or simple, when using The Handy over Bluetooth. Experimentation ultimately shows that the minimum command delay is causing jerkiness and missed commands.
My solution here, of reducing the minimum to 1ms, is admittedly based around not really understanding the purpose of the minimum command delay; I'm not really sure what that's for, where the advantage is to having this in places is. But I've presumed that the lower end of the range is the useful part, at least on modern hardware, so I've brought down the max to 50ms as well in order to facilitate easier configuration (ergo, reduce the precision required to set a specific min command delay setting).
Anywoo, a min command delay of 1ms makes The Handy usable and accurate over Bluetooth for even rather rapid scripts.