Feat/deadlines over time intervals #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annchous
approved these changes
Apr 10, 2022
Source/Domain/Kysect.Tamgly.Core/Entities/TimeIntervals/TimeInterval.cs
Outdated
Show resolved
Hide resolved
Source/Domain/Kysect.Tamgly.Core/Entities/RepetitiveWorkItems/SelectedDayOfWeek.cs
Outdated
Show resolved
Hide resolved
...ce/Domain/Kysect.Tamgly.Core/Entities/RepetitiveWorkItems/DailyPeriodicRepetitiveInterval.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Во время попытки реализовать #17 столкнулся с тем, что доработок нужно очень много. В первую очередь, захотелось вынести валидацию интервалов в отдельную сущность. А с появлением сущности, стало ясно, что на неё проще перевести дедлайны. Прошлая реализация дедлайнов смешивала в себе ответственность задания интервалов и дедлайнов. Кратко это можно понять по этому диффу: