Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cherry-pick abort and continue in UI #701

Closed
FredrikNoren opened this issue Feb 7, 2016 · 2 comments · Fixed by #710
Closed

Expose cherry-pick abort and continue in UI #701

FredrikNoren opened this issue Feb 7, 2016 · 2 comments · Fixed by #710
Labels

Comments

@FredrikNoren
Copy link
Owner

When you rebase or merge the UI shows "abort" and "continue" buttons when there's a conflict, but for cherry-pick this isn't implemented (it get's into a weird state where staging just looks like a bunch of files with changes, but they also have conflicts). Should probably look pretty much like what rebase and merge looks like.

@jung-kim
Copy link
Collaborator

/cherrypic operation does fail properly with merg-failed git error. However, problem is that cherry pick conflict doesn't get persisted.

for example, when merge conflict happens. next /status reports inMerging := true via checking few git files and front end knows to show "in conflict" view. However for cherry pick there is no way for us to know if we are "in cherry picking" state, as far as I know.

We can infer that we are in cherry pick failed state when any files in staging is in conflict as I believe that is the only situation where we would have files in conflicts and "inMerging" and "inRebasing" flags are false.

Thought?

@jung-kim
Copy link
Collaborator

jung-kim commented Mar 5, 2016

Ignore what I wrote above, it seems that git is creating ".../.git/CHERRY_PICK_HEAD" file upon cherry pick conflict, similar to merge conflicts.

jung-kim added a commit that referenced this issue Mar 24, 2016
handle cherry-pick conflict state fix: #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants