Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Grunt #895

Closed
FredrikNoren opened this issue Apr 1, 2017 · 7 comments
Closed

Remove Grunt #895

FredrikNoren opened this issue Apr 1, 2017 · 7 comments

Comments

@FredrikNoren
Copy link
Owner

Grunt is pretty dead by now. We could probably refactor the build script into something much simpler in just plain JS

@jung-kim
Copy link
Collaborator

jung-kim commented Apr 4, 2017

I like how mocha testings, bumping up dependencies, transpiling and other actions have a single point of entry. Do you really mean to get rid of Grunt? or replace with other solutions such as gulp or maybe even a make file?

@FredrikNoren
Copy link
Owner Author

I think most people just do plain .js build files these days (no gulp, no makefile). With async/await it's pretty easy to do multi-step asynchronous operations.

@jung-kim
Copy link
Collaborator

jung-kim commented Apr 5, 2017

What about babel? should we step away from that?

@FredrikNoren
Copy link
Owner Author

Bable is only used to make sure the backend code is compatible with old node versions right? If we removed it, the min version would be 6? Or 7?

@jung-kim
Copy link
Collaborator

jung-kim commented Apr 6, 2017

I think our code base will be at node 6 and considering client side code isn't es6 I think it is more safer. Honestly, babel is something that is seemingly becoming an industry standard that I don't personally have a strong affinity for so I don't really mind it but I would like for us to understand that it means we are limiting backward compatibility if we decided to keep es6 on server side.

@FredrikNoren
Copy link
Owner Author

Personally, I'm perfectly fine with only supporting the "live" versions of node; 6 is the current LTS. Either way, removing grunt doesn't necessarily mean we have to remove Babel

@jung-kim
Copy link
Collaborator

I'd be okay with just supporting node 5+ as well. Hopefully there are not many complaints...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants