Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build and watch to npm script #1374

Merged
merged 8 commits into from May 19, 2020
Merged

Conversation

campersau
Copy link
Collaborator

@campersau campersau commented May 17, 2020

using https://www.npmjs.com/package/nodemon
supersedes #1364
part of #895

Current console output is quite basic:

less:common
less public/css/styles.css
less:components
less components/app/app.css
less components/commitdiff/commitdiff.css
less components/crash/crash.css
less components/home/home.css
less components/imagediff/imagediff.css
less components/path/path.css
less components/refreshbutton/refreshbutton.css
less components/repository/repository.css
less components/stash/stash.css
less components/textdiff/textdiff.css
less components/branches/branches.css
less components/commit/commit.css
less components/graph/graph.css
less components/header/header.css
less components/staging/staging.css
browserify:common
browserify public/js/ungit.js
browserify:components
browserify components/app/app.bundle.js
browserify components/branches/branches.bundle.js
browserify components/commit/commit.bundle.js
browserify components/crash/crash.bundle.js
browserify components/dialogs/dialogs.bundle.js
browserify components/gitErrors/gitErrors.bundle.js
browserify components/header/header.bundle.js
browserify components/home/home.bundle.js
browserify components/imagediff/imagediff.bundle.js
browserify components/login/login.bundle.js
browserify components/path/path.bundle.js
browserify components/refreshbutton/refreshbutton.bundle.js
browserify components/remotes/remotes.bundle.js
browserify components/repository/repository.bundle.js
browserify components/submodules/submodules.bundle.js
browserify components/stash/stash.bundle.js
browserify components/textdiff/textdiff.bundle.js
browserify components/staging/staging.bundle.js
browserify components/commitdiff/commitdiff.bundle.js
browserify components/graph/graph.bundle.js
copy
copy public/js/raven.min.js
copy public/js/raven.min.js.map

@campersau campersau force-pushed the build branch 2 times, most recently from 2debb4a to 93d8e69 Compare May 17, 2020 15:01
Copy link
Contributor

@Hirse Hirse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup works, but it feels like a step backwards compared to the grunt setup.

It reruns the entire build on each change instead of just the required steps.
Maybe a better alternative to nodemon would be a combination of concurrently and chokidar.
I'm looking into possible setups.

CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@campersau campersau force-pushed the build branch 2 times, most recently from 919097b to b39707f Compare May 18, 2020 19:57
@campersau campersau merged commit 7b03413 into FredrikNoren:master May 19, 2020
@campersau campersau deleted the build branch May 19, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants