Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change .stagging background color #1142

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yukulele
Copy link

red seem like error message

@ylecuyer
Copy link
Contributor

As someone who doesn't like changes I have to say no please

@jung-kim
Copy link
Collaborator

jung-kim commented Oct 1, 2018

Ah... Is there a particular reasoning behind this change?

@yukulele
Copy link
Author

yukulele commented Oct 1, 2018

this seem like an error message:
screenshot_20180924_200540

this seem like a simple information:
screenshot_20180924_200628

@Hirse
Copy link
Contributor

Hirse commented Oct 23, 2018

I agree that red usually looks like an error message, but between the two screenshots the red looks like it fits better into the theme.
The green definitely has some contrast issues with the light-blue link text.

What about using a more neutral blue-gray?
(Green also looks like success and that message doesn't have either connotation.)

@yukulele
Copy link
Author

yes, i don't chose blue because of link color (i don't wont to change all the styles) but it's probably a better choice

@yukulele
Copy link
Author

yukulele commented Oct 24, 2018

I Try with neutral blue-grey:

screenshot_20181024_113610

@yukulele yukulele changed the title change .stagging background from red to green change .stagging background color Oct 24, 2018
use blue-grey
@yukulele
Copy link
Author

@Hirse I updated pull request

@Hirse
Copy link
Contributor

Hirse commented Oct 30, 2018

Could you also post a new image when you update the color, please?

Additionally, does this also affect the background of the commit area (when there are changes)? Should it?

@yukulele
Copy link
Author

yukulele commented Oct 31, 2018

it's the last screenshot #1142 (comment)

yes, it also affect commit area (and yes it should, I think)

@yukulele
Copy link
Author

screenshot_20181031_111248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants