Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changing remotes in remotes dropdown #1158

Merged
merged 4 commits into from
Nov 5, 2018

Conversation

zkxs
Copy link
Contributor

@zkxs zkxs commented Oct 30, 2018

When changing remotes using the dropdown in ungit 1.4.35, the following error occurs:

Firefox 64

TypeError: this.currentRemote is not a function[Learn More] remotes.js:97
    changeRemote remotes.js:97
    init/</< knockout:99
    dispatch jquery:5182
    add/elemData.handle jquery:4991

Chrome 69

Uncaught TypeError: this.currentRemote is not a function
    at Object.changeRemote (remotes.js:97)
    at HTMLAnchorElement.<anonymous> (knockout:99)
    at HTMLAnchorElement.dispatch (jquery:5183)
    at HTMLAnchorElement.elemData.handle (jquery:4991)

This issue prevents the user from changing remotes.

ylecuyer and others added 2 commits October 30, 2018 17:28
Co-Authored-By: zkxs <zkxs00@gmail.com>
Co-Authored-By: zkxs <zkxs00@gmail.com>
@zkxs
Copy link
Contributor Author

zkxs commented Oct 30, 2018

@ylecuyer's suggestion looks good. I wasn't happy about outerThis so I'm glad to see it go.

@jung-kim jung-kim merged commit aa26148 into FredrikNoren:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants