Better focus handling when creating branches and tags #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus handling when creating a new branch or tag wasn't very user friendly because the form go closed after the name input lost focus + 200ms. E.g. using the keyboard to tab through the buttons wasn't possible and also sometimes a direct click wasn't recognised because of the losing focus.
The branching form now is a form again so it is possible to create branches by just pressing enter. It got lost during the refactoring in SVG Animation rewrite #630
The clicktest has been updated to use a custom
insertandclickfunction because the standard nightmare methods call blur methods which interfered with the focus logic. This was reliable reproduceable on macOS: before after