Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for commit component with empty args object #1330

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

bakkerthehacker
Copy link
Contributor

Flatten total-lines-changed object to allow the commit object to not error when passed an empty object.

@campersau
Copy link
Collaborator

Under which circumstances an empty object would be passed in? How can I reproduce this?

@bakkerthehacker
Copy link
Contributor Author

I have had this issue occur a few times on a repo. Not sure if theres something weird going on that repo or if my diff tools are interfering with ungit, but I have gotten crashes in commit.js with total being undefined.

I am unable to determine exactly what causes this or how to reproduce it.

@campersau campersau merged commit 609cdce into FredrikNoren:master Apr 29, 2020
@bakkerthehacker
Copy link
Contributor Author

Thanks for fixing this, I did manage to get it to happen again:
Screenshot from 2020-05-04 11-39-39

@campersau
Copy link
Collaborator

Which version of ungit do you use?
Can you inspect the network trace for /gitlog requests and paste the json here?
Or you can try logging it here manually via console.log:

log = log ? log : [];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants