-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce jQuery UI imports and use Bootstrap tooltips #1340
Conversation
I just replaced the jQuery UI package in the dependencies, but was wondering if it makes more sense to move it to devDependencies, since it is only used when building the bundle file. @campersau What do you think? |
It seems you need to include core.css and autocomplete.css (cf https://www.drupal.org/project/aloha/issues/1827626#comment-6672476) (https://github.com/jquery/jquery-ui/tree/c6f1735249295bb37153861aa97e5b3e38d46b02/themes/base) I tried and it works well |
I have made #1343 |
I was trying to avoid having to add any CSS from jQuery-UI. |
@campersau, fixed the issue as @ylecuyer suggested by adding the jQuery-UI core.css (back) to our CSS/Less. |
This PR has two changes that are not easily possible to split.
Currently, ungit is (unintentionally probably) using the jQuery UI tooltips instead of the bootstrap ones.
Only import the jQuery UI widgets that are used, i.e.
autocomplete
jquery-ui-bundle
tojquery-ui
packageRemove jQuery UI styles import as we use our own (see Style autocompletes like dropdowns #1327)Add custom styling to bootstrap tooltips
Fix placement of tooltips in button groups