Import Bootstrap from npm and upgrade to latest 3.x #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because that apparently wasn't the best idea: ungit/components/graph/git-node.js Line 178 in a65cbc8 You could replace that with for example this const textBox = event.currentTarget.parentElement.querySelector('input[type="search"]');to fix it. |
This was referenced Jul 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes in bootstrap's minor version upgrades are fixes and security patches.
I only found the following changes required for us:
.pull-rightwith.dropdown-menu-rightwhite-spacefrom.dropdown-header.container-fluidclass for wide containerA further upgrade to 4.x is more complicated as it contains lots of breaking changes and switches from LESS to SCSS.