Skip to content

Commit

Permalink
cleanup: remove occurrences of WITH_DEBUG
Browse files Browse the repository at this point in the history
DEBUG like all ports features, must not ever be set in a port, they are
user facing features, that the user needs to enable in their
environment/make.conf, either by defining WITH_DEBUG globally, or by
setting WITH_DEBUG_PORTS with origin of ports they want DEBUG enabled
in.
  • Loading branch information
mat813 committed Apr 12, 2024
1 parent 38e3f72 commit 0660187
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 21 deletions.
1 change: 0 additions & 1 deletion biology/salmon/Makefile
Expand Up @@ -40,7 +40,6 @@ CMAKE_ARGS+= -DHAVE_FAST_MALLOC:BOOL=on \
-DFETCHED_PUFFERFISH:BOOL=on \
-DFETCHED_LIBGFF:BOOL=on \
-DFETCH_STADEN:BOOL=true
WITH_DEBUG= yes
LDFLAGS+= -lpthread

pre-configure:
Expand Down
1 change: 0 additions & 1 deletion biology/sra-tools/Makefile
Expand Up @@ -35,7 +35,6 @@ SHEBANG_GLOB= *.sh
GH_ACCOUNT= ncbi
GH_TUPLE+= ncbi:ncbi-vdb:${DISTVERSION}:vdb/ncbi-vdb

WITH_DEBUG= yes
CMAKE_ARGS+= -DVDB_LIBDIR:STRING=${WRKSRC}/ncbi-vdb/build/lib

post-extract:
Expand Down
4 changes: 0 additions & 4 deletions comms/limesuite/Makefile
Expand Up @@ -87,10 +87,6 @@ PLIST_SUB+= OCTAVE_OCT_SITE_DIR=${OCTAVE_OCT_SITE_DIR:sh}/
PLIST_SUB+= OCTAVE_M_SITE_DIR=${OCTAVE_M_SITE_DIR:sh}/
.endif

.if ${PORT_OPTIONS:MDEBUG}
WITH_DEBUG= yes
.endif

post-build:
# N.B. COPYTREE_BIN here chmods 555 which breaks CMAKE_INSTALL in user mode!
(cd ${BUILD_WRKSRC}/bin && ${COPYTREE_BIN} . ${STAGEDIR}${PREFIX}/bin)
Expand Down
2 changes: 0 additions & 2 deletions deskutils/qmediamanager/Makefile
Expand Up @@ -25,8 +25,6 @@ USE_GITHUB= yes

GH_ACCOUNT= outpaddling

WITH_DEBUG= yes

PLIST_FILES= bin/qmediamanager share/man/man1/qmediamanager.1.gz

do-install:
Expand Down
2 changes: 0 additions & 2 deletions devel/alire/Makefile
Expand Up @@ -32,8 +32,6 @@ DOCS_DESC= Install Design and Development documentation

.if empty(PORT_OPTIONS:MDEBUG)
_GPR_ARGS+= -XALIRE_BUILD_MODE=release
.else
WITH_DEBUG= yes
.endif

do-build:
Expand Down
1 change: 0 additions & 1 deletion devel/asfml/Makefile
Expand Up @@ -44,7 +44,6 @@ _GPR_ARGS= -j${MAKE_JOBS_NUMBER} -p

.if ${PORT_OPTIONS:MDEBUG}
_GPR_ARGS+= -XASFML_BUILD_MODE=debug
WITH_DEBUG= yes
.endif

post-extract:
Expand Down
1 change: 0 additions & 1 deletion emulators/virtualbox-ose/Makefile
Expand Up @@ -146,7 +146,6 @@ CONFLICTS_INSTALL+= virtualbox-ose
.if ${PORT_OPTIONS:MDEBUG}
KMK_BUILDTYPE= debug
KMK_FLAGS+= BUILD_TYPE=debug
WITH_DEBUG= yes
.else
KMK_BUILDTYPE= release
.endif
Expand Down
2 changes: 0 additions & 2 deletions graphics/glaxnimate/Makefile
Expand Up @@ -59,8 +59,6 @@ ALL_TARGET= all translations

OPTIONS_DEFINE= DEBUG

DEBUG_VARS= WITH_DEBUG=yes

.include <bsd.port.options.mk>

.if !${PORT_OPTIONS:MDEBUG}
Expand Down
4 changes: 0 additions & 4 deletions mail/opendkim/Makefile
Expand Up @@ -103,10 +103,6 @@ MAKE_ENV= INSTALL_STRIP_FLAG=${STRIP}

.include <bsd.port.options.mk>

.if ${PORT_OPTIONS:MDEBUG}
WITH_DEBUG= yes
.endif

.if ${PORT_OPTIONS:MFILTER}
SUB_FILES= pkg-message
WITHOUT_MILTER_CFLAGS= yes
Expand Down
1 change: 0 additions & 1 deletion multimedia/vlc/Makefile
Expand Up @@ -381,7 +381,6 @@ WITH_DVD_DEVICE?=/dev/cd0
.include <bsd.port.options.mk>

.if ${PORT_OPTIONS:MDEBUG}
WITH_DEBUG=yes
CONFIGURE_ARGS+=--enable-debug --disable-optimizations
CFLAGS+=-g -O0
CXXFLAGS+=-g -O0
Expand Down
2 changes: 0 additions & 2 deletions sysutils/npmount/Makefile
Expand Up @@ -19,6 +19,4 @@ GH_ACCOUNT= outpaddling

MAKE_ENV= MANDIR=${PREFIX}/share/man

WITH_DEBUG= yes

.include <bsd.port.mk>

0 comments on commit 0660187

Please sign in to comment.