Skip to content

Commit

Permalink
dns/void-zones-tools: fix unbound-killing bug
Browse files Browse the repository at this point in the history
void-zones-tools downloads a set of pre-defined lists of undesirable
domains and creates "voided" dns zones for Unbound, blocking access to
these domains via dns.

One of the default lists is no longer maintained, and was removed from
the upstream code. However, there hasn't been released a new version
after the change was made, thus the port has not been updated.
This has not been a problem up until now because the update script has
been downloading an empty file, essentially a no-op in the zone
creation/loading, but at some point today it started serving a domain
parking page, and the HTML of that page is being dumped into the dns
zone file resulting in parse errors and Unbound cannot start.

While waiting for upstream to tag a new version, I changed the port to
track the latest GitHub commit.  This fixes the issue for now.

PR:		274027
Upstream issue:	cyclaero/void-zones-tools#12
Reported by:	Robert William Vesterman <bob@vesterman.com>
MFH:		2023Q3
  • Loading branch information
vkarlsen authored and clausecker committed Sep 24, 2023
1 parent 397c116 commit 27c31c5
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 74 deletions.
4 changes: 2 additions & 2 deletions dns/void-zones-tools/Makefile
@@ -1,7 +1,7 @@
PORTNAME= void-zones-tools
DISTVERSIONPREFIX= v
DISTVERSION= 1.0.2
PORTREVISION= 7
DISTVERSION= 1.0.2-18
DISTVERSIONSUFFIX= -g204634a
CATEGORIES= dns

MAINTAINER= vidar@karlsen.tech
Expand Down
6 changes: 3 additions & 3 deletions dns/void-zones-tools/distinfo
@@ -1,3 +1,3 @@
TIMESTAMP = 1503447553
SHA256 (cyclaero-void-zones-tools-v1.0.2_GH0.tar.gz) = 5d276049372825c359fd281e1eee94a7771c2649f03e23796a55d7c959043510
SIZE (cyclaero-void-zones-tools-v1.0.2_GH0.tar.gz) = 16201
TIMESTAMP = 1695518114
SHA256 (cyclaero-void-zones-tools-v1.0.2-18-g204634a_GH0.tar.gz) = 38d364fc8850c86d4fc31a73c19dfc140e5ca992258cb7a5fad4ce267b433419
SIZE (cyclaero-void-zones-tools-v1.0.2-18-g204634a_GH0.tar.gz) = 16872
24 changes: 9 additions & 15 deletions dns/void-zones-tools/files/patch-Makefile
@@ -1,19 +1,13 @@
--- Makefile.orig 2018-08-26 02:54:47 UTC
--- Makefile.orig 2023-08-28 22:28:23 UTC
+++ Makefile
@@ -25,15 +25,7 @@

CC ?= clang
@@ -26,9 +26,7 @@
CC ?= clang
DV != $(CC) -dumpversion

-.if $(MACHINE) == "i386" || $(MACHINE) == "amd64" || $(MACHINE) == "x86_64"
-CFLAGS = $(CDEFS) -march=native -mssse3 -ffast-math
-CFLAGS = $(CDEFS) -march=native -mssse3
-.elif $(MACHINE) == "arm"
-CFLAGS = $(CDEFS) -fsigned-char
-.else
-CFLAGS = $(CDEFS)
-.endif
-
-CFLAGS += -std=c11 -g0 -Ofast -fstrict-aliasing -Wno-parentheses
+CFLAGS += -std=c11 -fstrict-aliasing -Wno-parentheses
PREFIX ?= /usr/local

HEADERS = binutils.h store.h
+.if $(MACHINE) == "arm"
CFLAGS = $(CDEFS) -fsigned-char
.else
CFLAGS = $(CDEFS)
54 changes: 0 additions & 54 deletions dns/void-zones-tools/files/patch-void-zones-update.sh

This file was deleted.

0 comments on commit 27c31c5

Please sign in to comment.