Skip to content

Commit

Permalink
www/qt5-webengine: Remove unnecessary ulimit calls
Browse files Browse the repository at this point in the history
Before linking, which is far at the end of the long building process,
the ulimit is tried to be set to 4096.  If this fails, it will cause
the whole linking process to abort and thus lead to a failed build,
which is the case when qt5-webengine is build with a non-root user in
a Poudriere jail.

The problem could be probably solved by substituting "&&" with ";"
in the affected lines, but in the course of bug 270041 it has become
apparent that an ulimit of 1024, which is poudriere's default,
is sufficient. [1]

This could also be successfully verified with qt5-webengine builds (with
either ALSA/PULSEAUDIO/SNDIO enabled and DEBUG set/unset) in non-root
poudriere jail hence remove the ulimit calls to fix the problem.

PR:		270041
Reported by:	Tomoaki AOKI, John Hein [1]
MFH:		2023Q3
With hat:	kde
  • Loading branch information
John Hein authored and knobix committed Aug 17, 2023
1 parent 1112b52 commit 2f01d32
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions www/qt5-webengine/files/patch-src_core_core__module.pro
@@ -1,11 +1,19 @@
No need to limit max open file descriptors.
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270041

--- src/core/core_module.pro.orig 2021-12-15 16:12:54 UTC
+++ src/core/core_module.pro
@@ -41,7 +41,7 @@ CONFIG -= bsymbolic_functions
@@ -41,10 +41,10 @@ QMAKE_INFO_PLIST = Info_mac.plist
# and doesn't let Chromium get access to libc symbols through dlsym.
CONFIG -= bsymbolic_functions

-linux {
+unix {
!ccache:!use_gold_linker:!use_lld_linker {
QMAKE_LINK="ulimit -n 4096 && $$QMAKE_LINK"
QMAKE_LINK_SHLIB="ulimit -n 4096 && $$QMAKE_LINK_SHLIB"
- QMAKE_LINK="ulimit -n 4096 && $$QMAKE_LINK"
- QMAKE_LINK_SHLIB="ulimit -n 4096 && $$QMAKE_LINK_SHLIB"
+ QMAKE_LINK="$$QMAKE_LINK"
+ QMAKE_LINK_SHLIB="$$QMAKE_LINK_SHLIB"
}
qtConfig(separate_debug_info): QMAKE_POST_LINK="cd $(DESTDIR) && $(STRIP) --strip-unneeded $(TARGET)"
}

0 comments on commit 2f01d32

Please sign in to comment.