Skip to content

Commit

Permalink
www/webkit2-gtk3: fix build with clang 16
Browse files Browse the repository at this point in the history
Clang 16 has a new error about integer values being outside the valid
range for enum types, which shows up when building www/webkit2-gtk3:

  /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.6/Source/WTF/wtf/URLHelpers.cpp:51:34: error: integer value 256 is outside the valid range of values [-256, 255] for this enumeration type [-Wenum-constexpr-conversion]
  constexpr auto scriptCodeLimit = static_cast<UScriptCode>(256);
                                   ^

Upstream fixed this in <https://commits.webkit.org/256560@main>, for
<https://bugs.webkit.org/show_bug.cgi?id=247770>, so apply that patch.
Thanks to Vladislav Shchapov for pointing out the upstream fix.

PR:		271827
Approved by:	portmgr (build blanket)
MFH:		2023Q2
  • Loading branch information
DimitryAndric committed Jun 8, 2023
1 parent f82231b commit 3b95146
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 4 additions & 1 deletion www/webkit2-gtk3/Makefile
@@ -1,12 +1,15 @@
PORTNAME= webkit
DISTVERSION= 2.34.6
PORTREVISION= 6
PORTREVISION= 7
CATEGORIES= www
MASTER_SITES= https://webkitgtk.org/releases/
PKGNAMESUFFIX= 2-gtk3
DISTNAME= ${PORTNAME}gtk-${PORTVERSION}
DIST_SUBDIR= gnome

PATCH_SITES= https://github.com/WebKit/WebKit/commit/
PATCHFILES= 06f9978e52a8408ed6c2c8296afb1e7449c2f1ee.patch:-p1 # https://bugs.webkit.org/show_bug.cgi?id=247770

MAINTAINER= gnome@FreeBSD.org
COMMENT= Opensource browser engine using the GTK+ 3 toolkit
WWW= https://webkitgtk.org/
Expand Down
4 changes: 3 additions & 1 deletion www/webkit2-gtk3/distinfo
@@ -1,3 +1,5 @@
TIMESTAMP = 1646438253
TIMESTAMP = 1685906637
SHA256 (gnome/webkitgtk-2.34.6.tar.xz) = 6bc8fd034aad0432a2459ce4fc7ee25ad65a4924c618bf8d93b52b0c1a84c1f6
SIZE (gnome/webkitgtk-2.34.6.tar.xz) = 24393340
SHA256 (gnome/06f9978e52a8408ed6c2c8296afb1e7449c2f1ee.patch) = 780812ffdff6b970c0e270e4605ec15325840723e2733c475371e92a56d257da
SIZE (gnome/06f9978e52a8408ed6c2c8296afb1e7449c2f1ee.patch) = 1661

0 comments on commit 3b95146

Please sign in to comment.