Skip to content

Commit

Permalink
emulators/virtualbox-ose: Remove unnecessary dependency on 32-bit com…
Browse files Browse the repository at this point in the history
…pat for amd64

32-bit in-kernel support and lib32 libs are not necessary for VirtualBox 6.x,
so just remove this requirement.
Also the port support amd64 only - remove I386 from PLIST_SUB.

PR:			266382
Tested by:		Olivier Certner <olivier.freebsd@free.fr>
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D40487
  • Loading branch information
VVD committed Jun 12, 2023
1 parent 5b3ea0f commit fd06fe3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
24 changes: 0 additions & 24 deletions emulators/virtualbox-ose/Makefile
Expand Up @@ -123,10 +123,6 @@ OPTIONS_DEFAULT+= PYTHON
CONFLICTS_INSTALL+= virtualbox-ose
.endif

.if ${ARCH} == "amd64"
_ELF32!= kldstat -q -m elf32 && echo yes || echo no
.endif

.if ${PORT_OPTIONS:MDEBUG}
KMK_BUILDTYPE= debug
KMK_FLAGS+= BUILD_TYPE=debug
Expand Down Expand Up @@ -196,14 +192,7 @@ PLIST_SUB+= SDK=""
PLIST_SUB+= SDK="@comment "
.endif

.if ${ARCH} == i386
KMK_ARCH= freebsd.x86
PLIST_SUB+= I386=""
.else
KMK_ARCH= freebsd.${ARCH}
PLIST_SUB+= I386="@comment "
.endif

PLIST_SUB+= ARCH="${KMK_ARCH}"

KMK_BUILDDIR= ${WRKSRC}/out/${KMK_ARCH}/${KMK_BUILDTYPE}
Expand Down Expand Up @@ -254,19 +243,6 @@ PLIST_SUB+= PYTHON_PYCDIR=/ \
CONFIGURE_ARGS+= --with-openssl-dir="${OPENSSLBASE}"
.endif

pre-everything::
.if ${ARCH} == "amd64"
.if ${_ELF32} != yes
@${ECHO_MSG} 'Requires 32-bit runtime support in kernel.'
@${ECHO_MSG} 'Rebuild kernel with "options COMPAT_FREEBSD32" and reboot.'
@${FALSE}
.elif !exists(/usr/lib32/libc.so)
@${ECHO_MSG} 'Requires 32-bit libraries installed under /usr/lib32.'
@${ECHO_MSG} 'Do: cd /usr/src; make build32 install32; service ldconfig restart'
@${FALSE}
.endif
.endif

post-patch:
@${ECHO_CMD} 'VBOX_PATH_APP_PRIVATE_ARCH = ${VBOX_DIR}' > \
${WRKSRC}/LocalConfig.kmk
Expand Down
2 changes: 0 additions & 2 deletions emulators/virtualbox-ose/pkg-plist
Expand Up @@ -402,8 +402,6 @@ lib/virtualbox/VBoxManage
lib/virtualbox/VBoxNetDHCP.so
@(root,%%VBOXGROUP%%,4510) lib/virtualbox/VBoxNetNAT
lib/virtualbox/VBoxNetNAT.so
%%I386%%lib/virtualbox/VBoxREM32.so
%%I386%%lib/virtualbox/VBoxREM64.so
lib/virtualbox/VBoxRT.so
%%X11%%@(root,%%VBOXGROUP%%,4510) lib/virtualbox/VBoxSDL
%%X11%%lib/virtualbox/VBoxSDL.so
Expand Down

0 comments on commit fd06fe3

Please sign in to comment.