Skip "legacy" devices if EVDEV is enabled #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wulf7
reviewed
Apr 29, 2018
udev-utils.c
Outdated
| if (enabled != -1) | ||
| return (enabled); | ||
|
|
||
| if (sysctlbyname("kern.features.evdev", &enabled, &len, NULL, 0) < 0) |
There was a problem hiding this comment.
I think sysctl's name should be kern.features.evdev_support
kern.features.evdev sysctl appears if evdev.ko is kld-loaded or compiled-in.
There was a problem hiding this comment.
Ok, thanks, I didn't know the difference between the two.
When EVDEV is enabled in the kernel, devices are exposed twice: * once through EVDEV (`/dev/input/event*`) * once through a device-specific driver (e.g. `/dev/atkbd*`) Users probably want a single one to be exposed and detected. Otherwise, they may need more rules in xorg.conf(5) to "blacklist" duplicates. So if EVDEV is enabled, we assume in libudev-devd that they want to use the EVDEV devices, not the "legacy" ones. This simplifies the input devices configuration. Note that this doesn't prevent the "conflict" between individual devices and multiplexers (kbdmux(8) and sysmouse(8)).
Mostly, they had trailing spaces.
dumbbell
force-pushed
the
ignore-legacy-devices-if-evdev-is-enabled
branch
from
58fb699
to
cde3c67
Compare
|
Any comments on the patch? I believe it would help to move forward with the X.Org server update to 1.19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.