Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ExtremProDark theme #229

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Added ExtremProDark theme #229

merged 1 commit into from
Jul 15, 2022

Conversation

MisterMakerNL
Copy link
Contributor

Added ExtremProDark PreferencePack
It's my first pull request ever.
@Chrismettal helped me to get it to work and tested it.

Added ExtremProDark PreferencePack
@luzpaz
Copy link
Collaborator

luzpaz commented Jul 15, 2022

Awesome!
Feedback: please convert tabs to the spaces in https://github.com/MisterMakerNL/ExtremeProDark/blob/main/package.xml (can be done easily in vscode)

@MisterMakerNL
Copy link
Contributor Author

I changed it, although on my mobile since I'm away from my computer.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 15, 2022

You missed a few tabs. I went ahead and reformatted the package.xml per the docs, see MisterMakerNL/ExtremeProDark#1

@luzpaz luzpaz merged commit 1c189a7 into FreeCAD:master Jul 15, 2022
@luzpaz
Copy link
Collaborator

luzpaz commented Jul 15, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants