-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can someone render this Architectural model with this WB ? #38
Comments
@howetuft what do you think? Care to take a swipe at this? |
@luzpaz Yes, with pleasure! Not sure our young Render module is mature enough to meet all expectations, but at least it is an interesting challenge, and also a good use case to feed our roadmap! |
@luzpaz (and I may also include @yorikvanhavre into the discussion, if he's OK) Hi! After several attempts, my conclusion is that our Render module is not yet featured-enough for this task. We lack some key lighting functionalities (sun light for instance, but Hosek-Wilkie skylight and area lights could be of some help as well), some ergonomics (ability to handle a large FreeCAD project into Render WB) and we should also go forward into material handling. So we cannot yet compare with what one can do by exporting the model into Blender and doing all the lighting and the material stuff into that software. Anyway, this is really a very, very interesting use case. Therefore, I take it as a challenge for our future developments, and I am going to make some additions to the roadmap (in README.md) based on that... |
Hi everybody (if there is still someone listening there...;-) I made some enhancements in FreeCAD-render, and I was able to get a first rendering of the above scene. Among the enhancements:
There is still much to do, especially about material and rendering fine tuning (denoising...), but at least there are some visible improvements that I can show. Here are the renderings: Lux (a bit burnt and quite noisy): @justnope I was notified by mail that you wrote a comment on this thread a few days ago, but I couldn't find your post here, nor answer you... If it is still relevant, could you please post it again? |
@howetuft fantastic progress, thank you for presenting it 😄 |
@howetuft I'm a bit angry at you. Well, not you as a person but at you as a developer. When you started this, I already made PRs to add materials, to fix cameras, etc... for several rendering engines. I included fixes to render windows, walls and multi-materials... This was indeed experimental code, but it worked. You completely tossed away the existing PRs. If you would've just asked what's next, I would've helped you and talked about the current problems rendering a large scene and what's missing. If you've discussed your plans, I would've refactored my code to go from experimental to production. |
@justnope Sorry, I don't understand: what PRs are you talking about? |
Edit: don't get me wrong. I'm extremely grateful you are taking it over. At least now there's progress :) (I know yorik is busy with more important things... I understand that, but since you're active and responsive I think I might talk to you directly about implementations and whatever?) |
OK, thank you for your precisions, because I was actually getting you wrong (not understanding why I should have disturbed anybody about closed unmerged PRs and as I was the only active contributor on the repo for the last 6 months...). |
Please add the link tot the discussion so we can track it from this ticket |
What do you mean exactly with "there are many things to do in the materials field"? Maybe I took the easy way and stored the material properties in the material card in freecad using custom properties. When I needed to render, I wrote an extra serializer for material type X and got the info from the material card. I've spend most of my time upgrading the serializers to the latest version of the renderers used. Debugging why some models didn't render, adding special cases for multi-materials, clones, etc... Adding code to serialize object vertex data because some renderers needed that... I don't deny there's some work to implement materials, but it's not coding work. It's discussing where to store the data and how. |
I agree that the main point is: where and how should the rendering material information be stored, and made available to the user. In my opinion, the key point is FreeCAD is no rendering software, and rendering is just an optional step in objects design. If you think your last year code was nearly ready for that, maybe you could rebase, lint/refactor (PEP8) and make a new proposition? |
There is an FC forum thread called [Architecture Masterpiece] Church of The Light. It would really benefit from an actual rendering the image to show how light illuminates the space of the structure. Is there someone interested in making this happen?
The text was updated successfully, but these errors were encountered: