get_rendering_string: don't use 'source.Proxy.type' attr to choose RenderHandler #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derHandler Scripted objects can create/set arbitrary attributes in their Proxy objects. Formerly, if an object's Proxy had a 'type' attribute, it would be used to determine which Rendering Handler should be used. This behaviour caused errors e.g. for FastenersWB objects, which used the type param to indicate the specification of a fastener. This commit changes the behaviour of the get_rendering_string function to check if an object needs a specific handler using the Proxy's python type.
alexneufeld
changed the title
alexneufeld
changed the title
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://forum.freecadweb.org/viewtopic.php?style=4&f=10&t=69321
Scripted objects can create/set arbitrary attributes in their Proxy
objects. Formerly, if an object's Proxy had a 'type' attribute, it would
be used to determine which Rendering Handler should be used. This behavior
caused errors e.g. for FastenersWB objects, which used the type param
to indicate the specification of a fastener.
This commit changes the behavior of the get_rendering_string function
to check if an object needs a specific handler using the Proxy's python type.
The example file in the linked forum post now works properly with this fix.