Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PartDesign] Add datum point,line .... #125

Closed
Kuzma30 opened this issue Apr 30, 2022 · 6 comments
Closed

[PartDesign] Add datum point,line .... #125

Kuzma30 opened this issue Apr 30, 2022 · 6 comments
Labels
missing in UI Strings that aren't exposed to translation in the FreeCAD UI

Comments

@Kuzma30
Copy link

Kuzma30 commented Apr 30, 2022

Illegal order for translation in Cyrillic. Word " parameters" must be first in translated text.
Must be "Параметри лінії" (better "Параметри опорної лінії")

Defined here

https://github.com/FreeCAD/FreeCAD/blob/d2253c7be4db12dbf9b89a53abfacff87692d216/src/Mod/PartDesign/Gui/TaskDatumParameters.cpp#L56

datumtext defined here

https://github.com/FreeCAD/FreeCAD/blob/d2253c7be4db12dbf9b89a53abfacff87692d216/src/Mod/PartDesign/Gui/ViewProviderDatum.cpp#L106-L122

Знімок екрана з 2022-04-30 18-02-51

We can define in ViewProviderDatum.cpp datumText = QObject::tr("Plane parameters"); //example
and delete word "parameters" from TaskDatumParameters.cpp if this not crash another thing :)

@kaktusus
Copy link
Contributor

kaktusus commented Apr 30, 2022

Confirm, problem reported here:
#11

additional reference here
#24

@Kuzma30
Copy link
Author

Kuzma30 commented May 1, 2022

Proposed solution
Kuzma30/FreeCAD@e1e172b

@Kuzma30
Copy link
Author

Kuzma30 commented May 1, 2022

Proposed solution for #24
Kuzma30/FreeCAD@fb58fd8

@luzpaz luzpaz added the missing in UI Strings that aren't exposed to translation in the FreeCAD UI label May 1, 2022
@Kuzma30
Copy link
Author

Kuzma30 commented May 2, 2022

@wwmayer @luzpaz Can I create pull-request in such form? No claims to the code (last 2 comment with links)?

@luzpaz
Copy link
Collaborator

luzpaz commented May 2, 2022

I think so. I say go for it!

@Kuzma30
Copy link
Author

Kuzma30 commented May 6, 2022

This strings will be on Crowdin during next update by Yorik.
Tested on test crowdin server. It's fix problem.

@Kuzma30 Kuzma30 closed this as completed May 6, 2022
abdullahtahiriyo pushed a commit to abdullahtahiriyo/FreeCAD_sf_master that referenced this issue May 16, 2022
berniev pushed a commit to berniev/FreeCAD that referenced this issue Jul 16, 2022
coreyoconnor pushed a commit to coreyoconnor/FreeCAD that referenced this issue Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing in UI Strings that aren't exposed to translation in the FreeCAD UI
Projects
None yet
Development

No branches or pull requests

3 participants