Back to pull request #10529

Gui: Add cancel button to transform task UI dialog #4463

Sign in to view logs

Triggered via pull request September 4, 2023 14:45

wwmayer

opened #10529

wwmayer:cancel-button-feature

Status Success

Total duration 1h 1m 36s

Artifacts 5

CI_master.yml

on: pull_request

Prepare / Prepare

Ubuntu_20-04 / Build

Ubuntu_22-04 / Build

Windows / Build

WrapUp / WrapUp

Annotations

5 errors and 11 warnings

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L177

'moc_TaskCSysDragger.cpp' file not found [clang-diagnostic-error]

Lint / Lint: src/Gui/TaskCSysDragger.h#L42

unknown type name 'ViewProviderDocumentObject' [clang-diagnostic-error]

Lint / Lint

Process completed with exit code 1.

Lint / Lint: src/Gui/TaskCSysDragger.h#L42

unknown type name 'ViewProviderDocumentObject'

Lint / Lint

Process completed with exit code 1.

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L48

180.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L52

constructor does not initialize these fields: tSpinBox, rSpinBox [cppcoreguidelines-pro-type-member-init]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L70

all parameters should be named in a function [readability-named-parameter]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L86

initializing non-owner 'QGridLayout *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L93

20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L94

assigning newly created 'gsl::owner<>' to non-owner 'Gui::QuantitySpinBox *' [cppcoreguidelines-owning-memory]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L104

assigning newly created 'gsl::owner<>' to non-owner 'Gui::QuantitySpinBox *' [cppcoreguidelines-owning-memory]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L106

180.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L138

15.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

Lint / Lint: src/Gui/TaskCSysDragger.cpp#L177

suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]

Lint / Lint

fatal error: 'moc_TaskCSysDragger.cpp' file not found

Artifacts

Produced during runtime

Name	Size
Lint-6074927685-Logs Expired	58.1 KB
Prepare-6074927685-Logs Expired	19.6 KB
Ubuntu_20-04-6074927685-Logs Expired	1.36 MB
Ubuntu_22-04-6074927685-Logs Expired	1.33 MB
Windows-6074927685-Logs Expired	14.5 MB