[PD] Hole dialog fixes

- when there is no profile the change of the hole cut type was not handled - for the deprecated hole cut types it must also be possible to use custom values
FreeCAD · Jun 25, 2022 · 360b428 · 360b428
1 parent 1aa897d
commit 360b428
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/Mod/PartDesign/Gui/TaskHoleParameters.cpp b/src/Mod/PartDesign/Gui/TaskHoleParameters.cpp
@@ -368,6 +368,15 @@ void TaskHoleParameters::holeCutTypeChanged(int index)
     if (HoleCutTypeString == "None" || HoleCutTypeString == "Counterbore"
         || HoleCutTypeString == "Countersink") {
         ui->HoleCutCustomValues->setEnabled(false);
+        if (HoleCutTypeString == "None") {
+            ui->HoleCutDiameter->setEnabled(false);
+            ui->HoleCutDepth->setEnabled(false);
+            ui->HoleCutCountersinkAngle->setEnabled(false);
+        }
+        if (HoleCutTypeString == "Counterbore")
+            ui->HoleCutCountersinkAngle->setEnabled(false);
+        if (HoleCutTypeString == "Countersink")
+            ui->HoleCutCountersinkAngle->setEnabled(true);
     }
     else { // screw definition
         // we can have the case that we have no normed values
@@ -379,6 +388,7 @@ void TaskHoleParameters::holeCutTypeChanged(int index)
                 ui->HoleCutCountersinkAngle->setEnabled(true);
         }
         else {
+            ui->HoleCutCustomValues->setEnabled(true);
             ui->HoleCutDiameter->setEnabled(false);
             ui->HoleCutDepth->setEnabled(false);
             ui->HoleCutCountersinkAngle->setEnabled(false);