Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assembly] Card 4 : When a joint is selected in the tree, its elements should highlight #10748

Closed
2 tasks done
PaddleStroke opened this issue Sep 20, 2023 · 10 comments
Closed
2 tasks done
Labels
WB Assembly Related to the Integrated Assembly Workbench

Comments

@PaddleStroke
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Following the introduction of #10611 :

When a joint is not being edited, if you select it, the selected elements (face, edge or vertex) should be highlighted.

Full version info

0.22 after #10611

Subproject(s) affected?

Other (specify in description)

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@PaddleStroke PaddleStroke changed the title [Assembly] When a joint is selected in the tree, its element should highlight [Assembly] Card 4 : When a joint is selected in the tree, its element should highlight Sep 20, 2023
@luzpaz luzpaz added the WB Assembly Related to the Integrated Assembly Workbench label Sep 20, 2023
@howie-j
Copy link
Contributor

howie-j commented Sep 23, 2023

Are we sure we want the element to be highlighted, not just the JCS?

@PaddleStroke
Copy link
Contributor Author

This is a good question. Perhaps it is not really helpful afterall. What really matter is the JCS I guess.

@PaddleStroke PaddleStroke changed the title [Assembly] Card 4 : When a joint is selected in the tree, its element should highlight [Assembly] Card 4 : When a joint is selected in the tree, its elements should highlight Sep 24, 2023
@howie-j
Copy link
Contributor

howie-j commented Sep 24, 2023

To highlight the selected JCS it's enough to set the property "OnTopWhenSelected" = "Enabled", see this commit: howie-j@940ed58

If that is sufficient, i can add it to my card 3 pr (not done yet)

@PaddleStroke
Copy link
Contributor Author

@howie-j It is not working on my side. The joint is hidden after accepting it. But selecting it does not show it nor does anything. Only toggling the visibility of the joint object shows the JCS.
Am I missing something?

@howie-j
Copy link
Contributor

howie-j commented Oct 20, 2023

Correct, it only highlights the selected joint when it's visible and selected in the tree view. #10747 must be solved first to actually make the joint visible when selected..

@howie-j
Copy link
Contributor

howie-j commented Oct 22, 2023

card_3_4.webm

Some progress update:
Joints are now selectable in the 3d view and tree view, and are highlighed when selected. I wanted proper selection and highlighting to work before trying to solve Card 3. A pr should be ready soon.

howie-j added a commit to howie-j/freecad that referenced this issue Oct 23, 2023
@tobiasfalk
Copy link
Contributor

Are we sure we want the element to be highlighted, not just the JCS?

I agree, but a way to also highlight the elements and not only the joints.
Maybe wit a option kn the dropdownmenue(right click) of the joint.

@pierreporte
Copy link

I don’t know if it’s better to write this here or on the PR. After seeing what @howie-j did this evening I thought of something that can be very useful when having parts very far apart: draw a line between the two JCSs. You could then follow the line and avoid mistakes. Catia does this and it saves the day. Whn you have a series of screws to put in holes, you’ll end up putting more than one screw in some holes, leaving some other empty. There could be an option: all lines visible (for all constraints), only selected constraint line is visible, no line visible.

@PaddleStroke
Copy link
Contributor Author

Also for distance joints, the distance could be writen along this line in the same style as sketcher dimensions

@pierreporte
Copy link

The dimensions should also appear for angle constraints.

Would the lines and dimensions open the constrain task box when double-clicked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
Development

No branches or pull requests

5 participants