-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Assembly] Card 10 : 'Fix part' missing #10754
Comments
What exactly would be the difference to Fixed joint? Does Fixed joint not already fix a part in space? |
Fixed joint goal is to fix two parts together through a contact point. Maybe the name 'Fixed joint' is not ideal it is prone to confusion with 'fix part'. If we can find another name that would be better. |
Now the ground and so makes sense, maybe Glew Jaoint as an alternative for Fix Joint |
I guess this command does not need the task view either, since you only need to select the object, not a JCS. |
Indeed, no taskbox required. |
Does this really need a toolbar icon then? Also anyone got any ideas for an icon? The lock icon is already used for the Fix Joint, I was thinking of changing the Fix Joint icon to be more like two parts interlocked together and using the lock icon for this instead. |
Yes! I was thinking just that. The padlock joint screams "locked" or "fix/ground" to me, unlike a "fixed joint" which should be to parts attached together via joint connectors. |
Why not a vertical cylinder with a ground mark on the bottom. |
That would be hard to show in a 32px icon and wouldn't be that clear I feel like. |
Very similar to another system with a name similar to Ondsel, but i like the icons 👍 One issue i see emerging: "Fixed Joint" and "Fixed Object" sounds very similar, but are totally different commands. |
Indeed the names are maybe going to be confusing. Though perhaps not if the tooltips are clear. I don't know. |
I personally really like ground for fixing part in space and glue for fixing one part to another. |
Then Why not fix to ground for the Fix part
This way the names may be longer but are more descriptive of what they do. If short versions are preferred, maybe FixGround and GlueParts. |
Just personal preference - If "Fix" can mean both then in my opinion it is better to choose wording that is not ambiguous for both operations. |
@qewer33 did you start working on this already ? If no please post the new icons and I'll tackle this now because I need it to solve assembly. |
I'm done with this card. Only the icons are missing. If you can send them it would be appreciated ! |
Sorry, I've been busy lately. It would also be great if you can tackle #10785. It's some quick JCS fixes suggested by wwmayer, shouldn't take too long. And here are the icons: Another note, it would be great if you can also use that new Fixed Joint icon on the "Joints" group under the Assembly container (instead of the current default folder group icon). |
Is there an existing issue for this?
Problem description
Following the introduction of #10611 :
We need a way to 'ground' or 'fix' parts.
This should perhaps take the form of a Joint as well. But with only 1 object obviously and no JCS required.
The question is, where do we put this. Some softwares use the mouse right click. I guess we could use a a toolbar entry. Perhaps in the joints toolbar, at the begining. And perhaps with a separator between it and other joints.
@qewer33 we need one more icon here :) and we need it to not be too confusing with the 'joint fixed' icon.
Full version info
Subproject(s) affected?
Other (specify in description)
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: