Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assembly] Card 10 : 'Fix part' missing #10754

Closed
2 tasks done
PaddleStroke opened this issue Sep 20, 2023 · 18 comments · Fixed by #10764
Closed
2 tasks done

[Assembly] Card 10 : 'Fix part' missing #10754

PaddleStroke opened this issue Sep 20, 2023 · 18 comments · Fixed by #10764
Labels
WB Assembly Related to the Integrated Assembly Workbench

Comments

@PaddleStroke
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Following the introduction of #10611 :

We need a way to 'ground' or 'fix' parts.
This should perhaps take the form of a Joint as well. But with only 1 object obviously and no JCS required.

The question is, where do we put this. Some softwares use the mouse right click. I guess we could use a a toolbar entry. Perhaps in the joints toolbar, at the begining. And perhaps with a separator between it and other joints.

@qewer33 we need one more icon here :) and we need it to not be too confusing with the 'joint fixed' icon.

Full version info

0.22 after 10611

Subproject(s) affected?

Other (specify in description)

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added the WB Assembly Related to the Integrated Assembly Workbench label Sep 20, 2023
@tobiasfalk
Copy link
Contributor

What exactly would be the difference to Fixed joint? Does Fixed joint not already fix a part in space?

@PaddleStroke
Copy link
Contributor Author

Fixed joint goal is to fix two parts together through a contact point.
Fix part would be fixing a part in space.

Maybe the name 'Fixed joint' is not ideal it is prone to confusion with 'fix part'. If we can find another name that would be better.

@tobiasfalk
Copy link
Contributor

Now the ground and so makes sense, maybe Glew Jaoint as an alternative for Fix Joint

@howie-j
Copy link
Contributor

howie-j commented Sep 20, 2023

I guess this command does not need the task view either, since you only need to select the object, not a JCS.
If i understand the use correctly, it's only purpose will be to prevent dragging an object around in space (or fix objects non-parametrically in an assembly)?

@PaddleStroke
Copy link
Contributor Author

Indeed, no taskbox required.
The point is usually to fix the first object. So that the whole assembly has an anchor part.
In solidworks for example, they just fix the first part you add in the assembly. Then you can unfix / fix by right clicking.
In onshape I think it's also a right click if I recall correctly.

@qewer33
Copy link
Contributor

qewer33 commented Sep 20, 2023

Indeed, no taskbox required. The point is usually to fix the first object. So that the whole assembly has an anchor part. In solidworks for example, they just fix the first part you add in the assembly. Then you can unfix / fix by right clicking. In onshape I think it's also a right click if I recall correctly.

Does this really need a toolbar icon then?

Also anyone got any ideas for an icon? The lock icon is already used for the Fix Joint, I was thinking of changing the Fix Joint icon to be more like two parts interlocked together and using the lock icon for this instead.

@howie-j
Copy link
Contributor

howie-j commented Sep 20, 2023

Also anyone got any ideas for an icon? The lock icon is already used for the Fix Joint, I was thinking of changing the Fix Joint icon to be more like two parts interlocked together and using the lock icon for this instead.

Yes! I was thinking just that. The padlock joint screams "locked" or "fix/ground" to me, unlike a "fixed joint" which should be to parts attached together via joint connectors.

@tobiasfalk
Copy link
Contributor

Also anyone got any ideas for an icon? The lock icon is already used for the Fix Joint, I was thinking of changing the Fix Joint icon to be more like two parts interlocked together and using the lock icon for this instead.

Why not a vertical cylinder with a ground mark on the bottom.
The ground like here on the top

@qewer33
Copy link
Contributor

qewer33 commented Sep 20, 2023

Why not a vertical cylinder with a ground mark on the bottom. The ground like here on the top

That would be hard to show in a 32px icon and wouldn't be that clear I feel like.

@qewer33
Copy link
Contributor

qewer33 commented Sep 20, 2023

Here is a new Fix Joint icon:

image

And proposal fix object icon:

image

@howie-j
Copy link
Contributor

howie-j commented Sep 20, 2023

Very similar to another system with a name similar to Ondsel, but i like the icons 👍

One issue i see emerging: "Fixed Joint" and "Fixed Object" sounds very similar, but are totally different commands.
Shoud we rename one of them to something else?

@PaddleStroke
Copy link
Contributor Author

Indeed the names are maybe going to be confusing. Though perhaps not if the tooltips are clear. I don't know.
'Glue joint' has been mentioned before. 'Fastened joint' could be one, but not so original.

@kadet1090
Copy link
Contributor

I personally really like ground for fixing part in space and glue for fixing one part to another.

@tobiasfalk
Copy link
Contributor

tobiasfalk commented Sep 20, 2023

I personally really like ground for fixing part in space...

Then Why not fix to ground for the Fix part

...glue for fixing one part to another.
And glue two parts for the other one.

This way the names may be longer but are more descriptive of what they do.

If short versions are preferred, maybe FixGround and GlueParts.

@kadet1090
Copy link
Contributor

Then Why not fix to ground for the Fix part

Just personal preference - If "Fix" can mean both then in my opinion it is better to choose wording that is not ambiguous for both operations.

@PaddleStroke
Copy link
Contributor Author

@qewer33 did you start working on this already ? If no please post the new icons and I'll tackle this now because I need it to solve assembly.

@PaddleStroke
Copy link
Contributor Author

I'm done with this card. Only the icons are missing. If you can send them it would be appreciated !

@qewer33
Copy link
Contributor

qewer33 commented Oct 6, 2023

I'm done with this card. Only the icons are missing. If you can send them it would be appreciated !

Sorry, I've been busy lately. It would also be great if you can tackle #10785. It's some quick JCS fixes suggested by wwmayer, shouldn't take too long.

And here are the icons:

Assembly_.zip

Another note, it would be great if you can also use that new Fixed Joint icon on the "Joints" group under the Assembly container (instead of the current default folder group icon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
Development

Successfully merging a pull request may close this issue.

6 participants