Leftovers from #10767

[luzpaz]

Originally posted by @wwmayer in #10767 (comment)

Some remarks:

• In order to avoid possible problems with scripting you should consider moving the view provider code into a separate file
• In the view provider you shouldn't add a callback function that is linked to the camera of the active view because this is error prone. If you open a new 3D view from the View menu then auto-scaling doesn't work.

Instead you should use the class SoShapeScale:

from pivy import coin

cube = coin.SoCube()

type = coin.SoType.fromName("SoShapeScale")
scale = type.createInstance()
scale.setPart("shape", cube)

graph = Gui.ActiveDocument.ActiveView.getSceneGraph()
graph.addChild(scale)
scale.scaleFactor = 10

CC @qewer33

[qewer33]

@wwmayer I can't find any documentation about SoShapeScale. Seems like it's a FreeCAD class and not an OpenInventor/Coin3D one? What differences does it have compared to SoScale? Does it auto scale shapes according to the view?

Also I took the view scaling approach from the transform dragger's source (it also works with the SoFieldSensor callback way), might make sense to also refactor that if SoShapeScale is better.

[wwmayer]

I can't find any documentation about SoShapeScale. Seems like it's a FreeCAD class and not an OpenInventor/Coin3D one?

Originally, it was developed by the makers of Coin3D but it's not an official OpenInventor class.

Does it auto scale shapes according to the view?

Yes, that's what it does. It's all done internally and you don't have to bother with the zooming.

Also I took the view scaling approach from the transform dragger's source (it also works with the SoFieldSensor callback way), might make sense to also refactor that if SoShapeScale is better.

It works as expected because when setting the view provider in edit mode it receives the currently active 3D viewer. Only in this viewer you see the draggers but not in any other 3D viewer that belongs to the document.

[luzpaz]

bump @qewer33 for status

[luzpaz]

@qewer33 ping

[qewer33]

I was busy the last few weeks, will handle this this weekend hopefully

[PaddleStroke]

@qewer33 was this solved ? It was concerning the JCS objects ?

[qewer33]

@PaddleStroke nope I haven't worked on it. It is regarding JCS objects (and also technically any other Coin object that autoscales like the transform dragger)