Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Std_Transparency : Toggle transparency of objects - not working as expected. #11353

Closed
2 tasks done
maxwxyz opened this issue Nov 11, 2023 · 7 comments · Fixed by #13180
Closed
2 tasks done
Assignees
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD

Comments

@maxwxyz
Copy link
Collaborator

maxwxyz commented Nov 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

The transparency toggle does not work as expected (#10805) @PaddleStroke
Example file: toggle-transparency.zip

  • If I select an item in the 3D view and toggle via right click menu it works. Selecting the body in the tree and toggle again: not working
  • Selecting a group in the tree and toggle: does not work
  • Selecting multiple in the tree an toggle: does work; select then some bodies in the 3D view and toggle: does not work for all selected.
  • Selection order in the tree matters some times if the feature works or not

I think it might have to do with the issue: #11132 where the space bar hide/show is bad in PartDesign WB as it chooses the last feature when you select in the 3D view and not the body as if you select it in the tree view.

Quick demo:

toggle_transparency.mp4

Full version info

OS: Windows 11 build 22631
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.34959 (Git)
Build type: Release
Branch: main
Hash: 640018bfa7878a79e1b3c220ddd488d66464dc70
Python 3.10.13, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.5, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * 3DfindIT 1.2.0
  * 3D_Printing_Tools
  * BIM 2021.12.0
  * CfdOF 1.24.7
  * CurvedShapes 1.0.4
  * Curves 0.6.14
  * Defeaturing 1.2.1
  * fasteners 0.4.68
  * freecad.gears 1.0.0
  * freecad_metal_workbench 0.0.1
  * OpenDark 2023.10.30
  * sheetmetal 0.3.1
  * Silk 0.1.5

Subproject(s) affected?

Core

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Nov 11, 2023

Maybe also related to the issue with the Std_ToggleObjects (which kind of does the same) not working as expected: #11131

@PaddleStroke
Copy link
Contributor

If I select an item in the 3D view and toggle via right click menu it works. Selecting the body in the tree and toggle again: not working
Selecting multiple in the tree an toggle: does work; select then some bodies in the 3D view and toggle: does not work for all selected.

Here the issue is that selecting in the view select the last feature of the Body. While selecting in the tree selects the body itself.

Selecting a group in the tree and toggle: does not work

Indeed group is currently not handled.

Selection order in the tree matters some times if the feature works or not

I guess this is the same issue as the first one.

So here I see 2 issues :

  • group is not supported.
  • For PartDesign bodies we should ignore the inner features and only toggle the body.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Nov 12, 2023

Yes, seems to fall back on the case when nested objects are in the selection. If this could be resolved, that always the body is selected (or toggled), this should also happen when hiding the item with spacebar (same procedure) #11132

@Roy-043 Roy-043 added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Nov 12, 2023
@PaddleStroke
Copy link
Contributor

This can be assigned to me, I'll get back to it at some point. Unless someone else want to tackle it

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Dec 17, 2023

@Roy-043 could you assign him?

@PaddleStroke
Copy link
Contributor

Also Roy mentioned a small problem in the placement in the menu. I'm posting here to centralized the things to solve for this tool :
image

@Freedman-CB1
Copy link

The expected behavior was to change the Transparency at the object level. Part and Group don't have their own transparency property so I would not expect them to be included in the selection process. I'm not sure about Arch. The idea of the toggle was a quick selection of an object/objects in the Workbench including Sketcher. Valid Sketcher selections will be from the tree only because Sketcher is sketch object modal in the 3D. Maybe the name "Transparency toggle" needs to be "Object transparency toggle" for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants