Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Sketcher: points of lines, circles, etc. cannot be turned into non-construction geometry #11920

Open
2 tasks done
pierreporte opened this issue Jan 7, 2024 · 4 comments
Labels
Mod: Sketcher Related to the Sketcher Workbench Priority: High Type: Feature FR for improvements or new features

Comments

@pierreporte
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

This prevents from creating patterns of points that can be picked from outside the sketch, without the need to keep the lines in normal mode.

Correct behaviour

  1. Create a point using Sketcher_CreatePoint.
  2. Select the point.
  3. Click on Sketcher_ToggleConstruction.
  4. The point turns white, as expected.

Wrong behaviour

  1. Create geometry (line, circle, whatever).
  2. Select one of the points of the geometry.
  3. Click on Sketcher_ToggleConstruction.
  4. The points remains red.

Workaround

It is possible to get the desired result by creating and converting standalone points first then connect them with construction geometry and eventually constraining them.

Full version info

OS: Ubuntu 23.10 (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.35510 (Git) AppImage
Build type: Release
Branch: main
Hash: da05f7c8e8b25ff783cc6c4eb3b73b640f134519
Python 3.10.13, Qt 5.15.8, Coin 4.0.2, Vtk 9.2.6, OCC 7.6.3
Locale: French/France (fr_FR)
Installed mods: 
  * OpenDark 2023.12.1

Subproject(s) affected?

Sketcher

Anything else?

This is for #6884

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Roy-043
Copy link
Contributor

Roy-043 commented Jan 8, 2024

I do not understand the reasoning. You can create a pattern from a point. Isn't it advisable to use PartDesign patterns instead of patterns (arrays) in sketches? And the endpoints of edges can already be accessed outside the sketch.

@Roy-043 Roy-043 added Type: Feature FR for improvements or new features Mod: Sketcher Related to the Sketcher Workbench labels Jan 8, 2024
@pierreporte
Copy link
Author

This is exactly to control PartDesign patterns: holes patterns and custom patterns (not planned yet AFAIK).

The endpoints of normal geometry can indeed be picked but they may not be wanted when creating a hole pattern. There can be quite a lot of geometry to define the pattern. If the hole tool picks every end point, there is going to be too many holes. Turning those that are wanted into normal points (I mean easily) allows the tools to pick up only normal points.

@pierreporte
Copy link
Author

@PaddleStroke is this bug easy to fix? It’s not very annoying right now but it will make normal points easier to use and the UX more consistent.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 2, 2024

Related: #12582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Sketcher Related to the Sketcher Workbench Priority: High Type: Feature FR for improvements or new features
Projects
Status: Todo (P1)
Development

No branches or pull requests

3 participants