Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Items are moved in reverse order, breaking dependencies #12287

Closed
2 tasks done
toddmo opened this issue Feb 7, 2024 · 2 comments · Fixed by #12301
Closed
2 tasks done

[Problem] Items are moved in reverse order, breaking dependencies #12287

toddmo opened this issue Feb 7, 2024 · 2 comments · Fixed by #12301
Labels
Bug This issue or PR is related to a bug

Comments

@toddmo
Copy link

toddmo commented Feb 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

When selecting multiple steps in the model, and then choosing "Move after..." from the context menu, the items are moved but their order flips from source to destination, making them in reverse dependency order at the new location. This makes no sense. It breaks the items in question and n more move operations have to be done to fix it, with each move involving a lengthy wait for re-computation.

Full version info

[code]
OS: Linux Mint 21.2 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.1.33694 (Git)
Build type: Release
Branch: (HEAD detached at 0.21.1)
Hash: f6708547a9bb3f71a4aaade12109f511a72c207c
Python 3.10.12, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.5, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * ProDarkThemePreferencePack 1.0.0
  * Assembly3 0.12.0
  * fasteners 0.4.75
  * Behave-Dark-Colors 0.1.1
  * freecad.gears 1.2.0
  * DynamicData 2.60.0
[/code]

Subproject(s) affected?

PartDesign

Anything else?

FreeCAD says, "Oh so you're trying to save time by moving more than 1 thing at a time? Oh Ok then, I'm gonna punish you for that by taking more time proportional to the items you tried to move, plus a bonus time penalty for good measure"

Code of Conduct

  • I agree to follow this project's Code of Conduct
LemonBoy added a commit to LemonBoy/FreeCAD that referenced this issue Feb 8, 2024
Remove and re-insert the selected objects at the specified point in the
tree while preserving their relative order.

The code used to insert them in reverse order.

Closes FreeCAD#12287
@maxwxyz maxwxyz added the Bug This issue or PR is related to a bug label Feb 11, 2024
chennes pushed a commit that referenced this issue Feb 19, 2024
Remove and re-insert the selected objects at the specified point in the
tree while preserving their relative order.

The code used to insert them in reverse order.

Closes #12287
@chennes
Copy link
Member

chennes commented Feb 19, 2024

@toddmo when the weekly builds today, can you please confirm that it fixes your issue? thanks!

@toddmo
Copy link
Author

toddmo commented Feb 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants