Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External geometry is not removed #13009

Closed
2 tasks done
kaiwas opened this issue Mar 17, 2024 · 8 comments · Fixed by #13297
Closed
2 tasks done

External geometry is not removed #13009

kaiwas opened this issue Mar 17, 2024 · 8 comments · Fixed by #13297
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench

Comments

@kaiwas
Copy link

kaiwas commented Mar 17, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

In version 0.22 (dated March 11, 2024), external geometry is not deleted when making multiple selections.
But it can be removed by selecting each element with a single click.
However, not all selected items are displayed in the selection filter.
Video demonstration.

Something probably goes wrong when multiple external geometry elements are selected at the same time.

video-2024-03-17_13.39.13.mp4

Full version info

0,22

Subproject(s) affected?

Sketcher

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 17, 2024 •
edited
Loading

can reproduce on

0.22dev Windows 11 

OS: Windows 11 build 22631
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36391 (Git)
Build type: Release
Branch: main
Hash: 52fffaf50ef8facea2ecfde23d6f1a7d3ad3d80c
Python 3.10.13, Qt 5.15.8, Coin 4.0.2, Vtk 9.2.6, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * 3DfindIT 1.2.0
  * BIM 2021.12.0
  * CfdOF 1.25.2
  * CurvedShapes 1.0.5
  * Curves 0.6.24
  * Defeaturing 1.2.2
  * fasteners 0.5.14
  * FEMbyGEN 2.1.0
  * freecad.gears 1.2.0
  * freecad_metal_workbench 0.0.1
  * OpenDark 2023.12.17
  * sheetmetal 0.4.3

Not possible to delete either in the 3D view when hitting del-key.
Also, the command Delete all geometry does not delete external geometry.

@maxwxyz maxwxyz added Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench and removed Needs triage labels Mar 17, 2024
@maxwxyz maxwxyz mentioned this issue Mar 19, 2024
Closed
@kaiwas kaiwas mentioned this issue Mar 27, 2024
Closed
2 tasks
@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 29, 2024

@PaddleStroke FYI

@PaddleStroke
Copy link
Contributor

I would guess this comes from the TNP work as well. Probably an index issue, as you can see in the video when he selects one of the edge it does not get selected in the widget. Though this is only guess work. Any idea when this got introduced?

@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 29, 2024

@bgbsww maybe any idea?

@bgbsww
Copy link
Contributor

bgbsww commented Mar 29, 2024

Well, maybe #13177 is related, but I have no idea when it was introduced. The index issue is a good guess, but I don't have a recollection of any work in that area. It does seem like there is a cluster of sketcher external geo related issues occurring after 21.2 (12/23) and starting before 3/15 or so. Anyone have a collection of past weekly builds and could narrow this a little?

CalligaroV added a commit to CalligaroV/FreeCAD that referenced this issue Apr 4, 2024
@CalligaroV
App/Toponaming: GeoFeature - fixes FreeCAD#13009 - fixes FreeCAD#13248
0c12f4c 
 * Restored previous logic of GeoFeature::getElementName()
 * Added precompiler directive to use the old logic of FC_USE_TNP_FIX isn't defined, otherwise use the new logic
 * Reworked SketchObjectTest::getElementName() as a consequence of the previous points

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
@CalligaroV CalligaroV mentioned this issue Apr 4, 2024
Merged
CalligaroV added a commit to CalligaroV/FreeCAD that referenced this issue Apr 4, 2024
@CalligaroV
App/Toponaming: GeoFeature - fixes FreeCAD#13009 - fixes FreeCAD#13248
6efe294 
 * Restored previous logic of GeoFeature::getElementName()
 * Added precompiler directive to use the old logic if FC_USE_TNP_FIX isn't defined, otherwise use the new logic
 * Reworked SketchObjectTest::getElementName() as a consequence of the previous points

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
@CalligaroV
Copy link
Contributor

Hi Everyone!

I gave a look at this issue and yes, it's related to some modifications introduced for TNP.

For now I found a fix (probably temporary) that should solve both this issue and #13248.
The full fix is more complicated and needs to import more code from RT fork, I already started working on that.

Regardless for that, I opened #13297 that contains the temporary fix.
Can you try it? On my local build it works.

TIA!

@CalligaroV CalligaroV mentioned this issue Apr 4, 2024
Closed
2 tasks
chennes pushed a commit that referenced this issue Apr 5, 2024
@CalligaroV @chennes
App/Toponaming: GeoFeature - fixes #13009 - fixes #13248
6779c91 
 * Restored previous logic of GeoFeature::getElementName()
 * Added precompiler directive to use the old logic if FC_USE_TNP_FIX isn't defined, otherwise use the new logic
 * Reworked SketchObjectTest::getElementName() as a consequence of the previous points

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
wwmayer pushed a commit to wwmayer/FreeCAD that referenced this issue Apr 6, 2024
@CalligaroV @wwmayer
App/Toponaming: GeoFeature - fixes FreeCAD#13009 - fixes FreeCAD#13248
53594f7 
 * Restored previous logic of GeoFeature::getElementName()
 * Added precompiler directive to use the old logic if FC_USE_TNP_FIX isn't defined, otherwise use the new logic
 * Reworked SketchObjectTest::getElementName() as a consequence of the previous points

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
This was referenced Apr 15, 2024
Closed
Open
@CalligaroV CalligaroV mentioned this issue Apr 29, 2024
Merged
This was referenced Jun 1, 2024
Merged
Open
@kaiwas
Copy link
Author

kaiwas commented Jun 16, 2024 •
edited
Loading

@maxwxyz Open again (((
#13297 (comment)

@maxwxyz maxwxyz reopened this Jun 16, 2024
@FEA-eng
Copy link
Contributor

FEA-eng commented Jun 25, 2024

It seems to be working now with #14437 merged.

@maxwxyz maxwxyz closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

App/Toponaming: GeoFeature - fixes #13009 - fixes #13248 CalligaroV/FreeCAD
6 participants
@maxwxyz @PaddleStroke @kaiwas @FEA-eng @bgbsww @CalligaroV