Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with TabBar workbench selector #13286

Open
2 tasks done
FEA-eng opened this issue Apr 3, 2024 · 10 comments · May be fixed by #13721
Open
2 tasks done

Issues with TabBar workbench selector #13286

FEA-eng opened this issue Apr 3, 2024 · 10 comments · May be fixed by #13721
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX

Comments

@FEA-eng
Copy link
Contributor

FEA-eng commented Apr 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

I really like the idea of the new TabBar workbench selector introduced by #12270 but when I selected the Left corner position of the TabBar, I ended up with this:

tab bar

It's still at the top for some reason, doesn't show all the workbenches (shouldn't it automatically scroll to the right when hovering next to the end of the bar if there are more workbenches?) and, most importantly, I can't access the menu bar to go to Preferences to restore the old selector.

The same happens on two different Windows computers.

@PaddleStroke Can you fix it?

Full version info

OS: Windows 10 build 19045
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36731 (Git)
Build type: Release
Branch: main
Hash: ac1d887336826c59321352f49a195bf1ef8be2f0
Python 3.11.8, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Polish/Poland (pl_PL)

Subproject(s) affected?

Core

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@PaddleStroke
Copy link
Contributor

PaddleStroke commented Apr 3, 2024

'Left corner position' is a setting to put the wb selector widget in the menubar corner widget. Not to dock the toolbar on the left side.

In your situation it's kind of 'you get what you asked for' in the sense that if shows the widget in the left corner widget, pushing out the menu as you have so many workbenches.

Now the fact that you cannot access the menu is indeed an issue. However you can actually still access the preferences because clicking on the '+ more' tab you have a link to Preferences where you can disable a proper amount of workbench to get it to a reasonable size (or disable this corner widget option).

Note that this 'corner widget' option is likely going to be removed soon anyway as RT said he will implement docking areas instead. See #12979.
So the confusion you had if any will be removed.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 3, 2024

Ok, I accessed the preferences with Gui.runCommand("Std_DlgPreferences"). Changing to Icon (instead of Icon & Text) made me realize that the menu bar is on the right from the TabBar selector (previously outside of the screen). I thought that the Left corner position would move the TabBar automatically to the right side of the screen but that apparently requires the Toolbar position and moving the toolbar to the left manually. So only the issue with too long non-scrollable TabBar when there are many workbenches is left.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 3, 2024

However you can actually still access the preferences because clicking on the '+ more' tab you have a link to Preferences where you can disable a proper amount of workbench to get it to a reasonable size (or disable this corner widget option).

This button is also outside of the screen when both icon and text are shown. But ok, I admit that it's a fault of having too many workbenches to fit in such a bar. So maybe this should be turned into a feature request to add some automatic or manual scrolling. Perhaps even the Toolbar position could use it.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 3, 2024

Now I got this:

tabbar

No idea what happened here :P

@maxwxyz maxwxyz added Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX labels Apr 3, 2024
@PaddleStroke
Copy link
Contributor

Let me know if you can find how to reproduce please

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 3, 2024

Let me know if you can find how to reproduce please

Setting what I showed there in Preferences (TabBar, Toolbar, Icon & Text) and restarting does this for me.

@PaddleStroke
Copy link
Contributor

At least one solution wuold be to put the + as the first entry. So that even if list is too long you can easily access preferences.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 5, 2024

At least one solution wuold be to put the + as the first entry. So that even if list is too long you can easily access preferences.

Right, that would make sense. But workbenches going outside of the screen don't look good so maybe in the future the code could automatically put the workbenches that don't fit on the screen under the More (+) button. Or the aforementioned scrolling could be added.

There's still that issue with the whole window getting covered by toolbars though. Do you know what can be causing it?

@PaddleStroke
Copy link
Contributor

I don't know what can cause this and I cannot reproduce. You are stuck in this situation?

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 18, 2024

I don't know what can cause this and I cannot reproduce. You are stuck in this situation?

It still happens on some of my Windows computers:

tabbar 2

No idea why only on some, maybe it's due to a specific screen resolution. The number of active workbenches is similar on all of them. Preference settings should be similar too.

kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 4, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
@kadet1090 kadet1090 linked a pull request May 4, 2024 that will close this issue
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 4, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 4, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 5, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 5, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 6, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 6, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 6, 2024
This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants