Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechDraw: ProjectShape tool is in wrong workbench. Should be in Draft. #13347

Open
2 tasks done
PaddleStroke opened this issue Apr 7, 2024 · 7 comments
Open
2 tasks done
Labels
Feature FR for improvements or new features UI/UX WB Draft Related to the Draft Workbench WB TechDraw Related to the TechDraw Workbench

Comments

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Apr 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

TechDraw_ProjectShape does not belong to techdraw workbench. It should be moved to Draft (or Part alternatively).
@yorikvanhavre Are you interested in moving this tool to Draft?

forum discussion

Full version info

0.22

Subproject(s) affected?

Techdraw

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added WB Draft Related to the Draft Workbench WB TechDraw Related to the TechDraw Workbench UI/UX Feature FR for improvements or new features labels Apr 7, 2024
@FEA-eng
Copy link
Contributor

FEA-eng commented Apr 7, 2024

Right, it shouldn't belong to TD. It should probably go to Draft like Shape2DView but Part would also make sense.

@luzpaz
Copy link
Contributor

luzpaz commented Apr 7, 2024

cc @Roy-043

@ayushgupta9906
Copy link

I want to work on this issue. Please Assign this to me.
Thanks

@Roy-043
Copy link
Contributor

Roy-043 commented Apr 10, 2024

Draft already has Draft_Shape2DView. That tool relies on TD code internally. Adding TechDraw_ProjectShape to Draft seems redundant.

@PaddleStroke
Copy link
Contributor Author

Hmm this Shape2DView seems very similar to ProjectShape. But I don't know these tools well so I can't say for sure. Perhaps it is not worth keeping both then? Should be just remove ProjectShape? @yorikvanhavre ?

@yorikvanhavre
Copy link
Member

Draft_Shape2DView has a few additional functionalities such as the ability to fill closed areas or show cut lines. OTOH TD projectShape is probably faster. So at the moment although they are similar I can't say one should be removed.

Having both in Draft is a possible, but IMHO this will not make things easier to the user... There will now be two very similar tools one next to the other.

Having it in Part wouldn't be good because it would make Part depend on TechDraw when it's currently the contrary.

What about keeping it in TD but putting in some kind of "utils" submenu?

@PaddleStroke
Copy link
Contributor Author

If Draft_Shape2DView is a super set of TechDraw_ProjectShape, then there is no reason to keep it around. Unless it is indeed significantly faster. Could you please make a little test to see if it is actually faster?

  • If it is not faster then we can just remove TechDraw_ProjectShape.
  • If it is faster, is there not a way to make Draft_Shape2DView faster by using what makes TechDraw_ProjectShape faster?
  • If it is faster but speed cannot be transfered to Draft_Shape2DView, then having both in draft together would make most sense imo, in a command group for example. With tooltip that explain the differences.

If we move to Part, we don't have to make Part depend on TD, we can move the code to Part probably not just the tool.

Leave in TD but only in menu, I think this is not as good as a solution. It will just be completely hidden and cluttering a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features UI/UX WB Draft Related to the Draft Workbench WB TechDraw Related to the TechDraw Workbench
Projects
None yet
Development

No branches or pull requests

7 participants