Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TechDraw: use c++11 compatible code in TechDraw/App/DrawUtil.cpp #13410

Closed
luzpaz opened this issue Apr 11, 2024 · 3 comments · Fixed by #13441
Closed

TechDraw: use c++11 compatible code in TechDraw/App/DrawUtil.cpp #13410

luzpaz opened this issue Apr 11, 2024 · 3 comments · Fixed by #13441
Labels
Coding: C++ Coding issue related to C++ Good first issue Suitable issues for potential first-time contributors Refactor PRs that only refactor code WB TechDraw Related to the TechDraw Workbench

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Apr 11, 2024

FreeCAD/src/Mod/TechDraw/App/DrawUtil.cpp

Lines 122 to 123 in cc96f27

if (boost::regex_search(begin, end, what, re, flags)) {
return what.str();//TODO: use std::stoi() in c++11

@luzpaz luzpaz added WB TechDraw Related to the TechDraw Workbench Refactor PRs that only refactor code Coding: C++ Coding issue related to C++ Good first issue Suitable issues for potential first-time contributors labels Apr 11, 2024
@WandererFan
Copy link
Contributor

The comment looks like a cut and paste error from getIndexFromName. getGeomTypeFromName returns a string, so there is no conversion to integer required.

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 11, 2024

@WandererFan should i delete the comment then ?

@WandererFan
Copy link
Contributor

Yes please.

luzpaz added a commit to luzpaz/FreeCAD that referenced this issue Apr 13, 2024
@luzpaz
TD: Remove incorrect TODO
d0319b0 
Closes FreeCAD#13410
@luzpaz luzpaz mentioned this issue Apr 13, 2024
Merged
wwmayer pushed a commit that referenced this issue Apr 13, 2024
@luzpaz @wwmayer
TD: Remove incorrect TODO
a3d7216 
Closes #13410
@github-actions github-actions bot mentioned this issue Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this issue May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Coding: C++ Coding issue related to C++ Good first issue Suitable issues for potential first-time contributors Refactor PRs that only refactor code WB TechDraw Related to the TechDraw Workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TD: Remove incorrect TODO luzpaz/FreeCAD
2 participants
@WandererFan @luzpaz