Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [Regression] Pocket becomes a pad when next object ofter a polar pattern #6584

Closed
1 task done
donovaly opened this issue Mar 14, 2022 · 7 comments
Closed
1 task done

[Bug] [Regression] Pocket becomes a pad when next object ofter a polar pattern #6584

donovaly opened this issue Mar 14, 2022 · 7 comments
Labels
Bug This issue or PR is related to a bug WB Part Design Related to the Part Design Workbench
Milestone
0.20

Comments

@donovaly
Copy link
Member

donovaly commented Mar 14, 2022 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Forums discussion

https://forum.freecadweb.org/viewtopic.php?p=579381#p579381

Version

0.19 (Release)

Full version info

OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24267 +148 (Git)
Build type: Release
Branch: Branch_0.19.4
Hash: 476ecf091941bead59b14e44afa6064d5a66afa3
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.3
Locale: German/Germany (de_DE)

Subproject(s) affected?

PartDesign

Issue description

See https://forum.freecadweb.org/viewtopic.php?p=579381#p579381 for a description and example file.

We found out that the issue occurred with aa19f8b but this commit is not directly to blame.

However, a mustfix for 0.20 since padding is an essential feature for 3D of course ;-)
@donovaly donovaly added this to the 0.20 milestone Mar 14, 2022
@donovaly
Copy link
Member Author

@realthunder , since you did much to PD in your branch, maybe you have an idea what is causing this nasty issue?

@0penBrain
Copy link
Contributor

0penBrain commented Mar 16, 2022 •
edited

I had a quick look but can't find anything obvious in the code that would create this. I'm balanced between a FC bug and an OCC one...
Should have updated forum tab before writing. Caused by aa19f8b

@donovaly donovaly changed the title [Bug] Pocket becomes a pad when next object ofter a polar pattern [Bug] [Regression] Pocket becomes a pad when next object ofter a polar pattern Mar 17, 2022
@luzpaz luzpaz added Bug This issue or PR is related to a bug WB Part Design Related to the Part Design Workbench labels Mar 18, 2022
@donovaly donovaly mentioned this issue Mar 21, 2022
Closed
2 tasks
@donovaly
Copy link
Member Author

donovaly commented Mar 21, 2022 •
edited

Caused by aa19f8b

Since this commit does not seem the be the origin, just a symptom, could it be that this commit causes this bug?: 03da9d3501
(this causes also a polar pattern bug: #6641)

@donovaly
Copy link
Member Author

could it be that this commit causes this bug?: 03da9d3501

No, reverting this commit does not fix the issue.

@donovaly
Copy link
Member Author

Also reverting aa19f8b does not fix the issue.

AjinkyaDahale added a commit to AjinkyaDahale/FreeCAD that referenced this issue Mar 26, 2022
@AjinkyaDahale
[Part] Check for flipped solids even with current OCCT
3e54bd8 
Fixes FreeCAD#6584.

Under certain circumstances the created `TopoDS_Solid`s can be inverted. For
issue FreeCAD#6584, this happened when creating PolarPattern.

If this commit causes side-effects/performance issues, an alternatives could be
to add this check in `PartDesign::Feature::getSolid()`.
@AjinkyaDahale AjinkyaDahale mentioned this issue Mar 26, 2022
Closed
AjinkyaDahale referenced this issue in AjinkyaDahale/FreeCAD Mar 28, 2022
@AjinkyaDahale
[PD] Check for reversal in PartDesign::Feature::getSolid()
864a64d 
Fixes FreeCAD#6584.

Under certain circumstances the created `TopoDS_Solid`s can be inverted. For
issue FreeCAD#6584, this happened when creating PolarPattern.
@AjinkyaDahale AjinkyaDahale mentioned this issue Mar 28, 2022
Closed
AjinkyaDahale added a commit to AjinkyaDahale/FreeCAD that referenced this issue Mar 28, 2022
@AjinkyaDahale
[Part] Check for flipped solids even with current OCCT
229f18a 
Fixes FreeCAD#6584.

Under certain circumstances the created `TopoDS_Solid`s can be inverted. For
issue FreeCAD#6584, this happened when creating PolarPattern.

If this commit causes side-effects/performance issues, an alternatives could be
to add this check in `PartDesign::Feature::getSolid()`.
AjinkyaDahale referenced this issue in AjinkyaDahale/FreeCAD Mar 28, 2022
@AjinkyaDahale
[PD] Check for reversal in PartDesign::Feature::getSolid()
37589a0 
Fixes FreeCAD#6584.

Under certain circumstances the created `TopoDS_Solid`s can be inverted. For
issue FreeCAD#6584, this happened when creating PolarPattern.
@0penBrain
Copy link
Contributor

@AjinkyaDahale Could you clarify about difference between 6665 and 6671 ? What are pros & cons of each ? Is one covering more cases ?

@AjinkyaDahale
Copy link
Contributor

@AjinkyaDahale Could you clarify about difference between 6665 and 6671 ?

Just where the inversion check happens. A user there did some benchmarks and found a significant speed difference in #6665. HOWEVER, they have since found an error in that test so now it looks quite better.

What are pros & cons of each ?

I guess #6671 does the check at the very end, so it happens even if refine is set to false. #6665 on the other hand will also correct the loose solids if that is wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This issue or PR is related to a bug WB Part Design Related to the Part Design Workbench
Projects
None yet
Milestone
0.20
4 participants
@donovaly @luzpaz @AjinkyaDahale @0penBrain