Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix Draft_Snap_Intersection for self-intersecting objects #6780

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Apr 22, 2022

This is a followup of a previous PR of mine (#5202). Removing the last object from the self.lastObj list prevents the detection of intersections of self-intersecting objects.

This was reported on the Forum. But I can't find the actual topic right now.

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

@github-actions github-actions bot added the Mod: Draft Related to the Draft Workbench label Apr 22, 2022
@freecadci
Copy link

pipeline status for feature branch PR_6780. Pipeline 522630656 was triggered at f86fa72. All CI branches and pipelines.

@Roy-043
Copy link
Contributor Author

Roy-043 commented Apr 22, 2022

Found the Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=3&t=67999

@freecadci
Copy link

pipeline status for feature branch PR_6780. Pipeline 523000225 was triggered at f86fa72. All CI branches and pipelines.

@donovaly
Copy link
Member

Thanks!

@donovaly donovaly merged commit a222bc6 into FreeCAD:master Apr 29, 2022
@Roy-043 Roy-043 deleted the Draft-Fix-Draft_Snap_Intersection-for-self-intersecting-objects branch April 30, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants