[Feature Request] Add cancel button in the Transform task UI

[rahmanshaber]

Is there an existing request for this?

• I have searched the existing requests

Forums discussion

https://forum.freecadweb.org/viewtopic.php?f=34&t=71598

Subproject(s) affected?

No response

Idea description

Sometime we just move a part to compare with another, but to go back to previous position we need to click OK and then undo the changes.
But if the part is filled with details then it takes time to undo the changes. So with a "Cancel" button this can be prevented.
Also if you move the part in 6 step than you have to press ctrl+z 6 times to go to previous position.

With the cancel button that will be reduced and the UI consistency will also be maintained.

Requested UI

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[luzpaz]

@adrianinsaval do you want to tackle this? 😜

[adrianinsaval]

I agree with the request but don't really know how to do it so it's gonna be a pass from me for the time being, perhaps at a later time I'll learn some about all the transaction and undo mumbo jumbo.

[luzpaz]

@PaddleStroke since you've been diving deep in to Sketcher code, would you have a moment to make a PR for this ?

[luzpaz]

Per wwmayer in #9647 (comment)

Just by adding a Cancel button the issue is not solved because when clicking the button after a transformation the geometry doesn't jump back.

What's still needed is:

* the transaction handling must be moved from ViewProviderDragger (dragStartCallback/dragFinishCallback) to TaskCSysDragger  
* TaskCSysDragger::accept() must commit the pending transaction
* implement TaskCSysDragger::reject() that just aborts a pending transaction

[Aryan01b]

@luzpaz, Can i work on this issue.
if so, then Which file should be modified to add the feature?

[luzpaz]

@Aryan01b perhaps @PaddleStroke can give some insight ?

[PaddleStroke]

Same as Adrian here, I don't know the transaction system. But wwmayer has already said what needs to be done in the message you quoted no?

…

On Mon, Aug 21, 2023, 02:38 luzpaz ***@***.***> wrote: @Aryan01b <https://github.com/Aryan01b> perhaps @PaddleStroke <https://github.com/PaddleStroke> can give some insight ? — Reply to this email directly, view it on GitHub <#7517 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEYO6MLRPYO5RQO5HLTMSOTXWKUZPANCNFSM6AAAAAAQTIMHO4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[luzpaz]

Thanks for responding @PaddleStroke, just for clarification, I was quoting wwmayer from a closed PR (not a direct message). It's not clear what file(s) he was referring to specifically.

[didendron]

@luzpaz, Could I pick this as my first issue?

[luzpaz]

@didendron go for it!