[Bug] App::Link breaks when opening a Symlinked FCStd

[leoheck]

Is there an existing issue for this?

• I have searched the existing issues

Forums discussion

https://forum.freecadweb.org/viewtopic.php?f=3&t=72491#p632344

Version

0.21 (Development)

Full version info

OS: Ubuntu 22.04.1 LTS (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.21.30492 (Git) AppImage
Build type: Release
Branch: master
Hash: b4578fb3eae842eb510a1bc055d07d369a67ce94
Python 3.10.6, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * Defeaturing 1.2.0
  * A2plus 0.4.59c
  * Curves 0.5.8
  * fasteners 0.4.12
  * lattice2 1.0.0
  * Assembly4 0.12.4
  * kicadStepUpMod 10.15.1
  * Help 1.0.3

Subproject(s) affected?

No response

Issue description

When a Symlinked file is opened with Freecad, if it is not in the same folder with it's target (which is most of the time the case) the links to the linked files inside the file doesn't work anymore, since they are not relative to the path of the symlink.

A simple solution would follow the symbolic link to open the actual file, instead, when the given file is a symlink.

Anything else?

Discussion started here Zolko-123/FreeCAD_Assembly4#370 (comment)

Code of Conduct

• I agree to follow this project's Code of Conduct

[leoheck]

A simple solution would follow the symbolic link to open the actual file, instead, when the given file is a symlink.

And maybe, iterate since multi-symlink levels may exist.

[luzpaz]

I seem to recall an pre-existing issue regarding symlinks....brb

Edit: indeed the original issue (#5592) is now closed. It was closed in #7034 by @FlachyJoe

[Zolko-123]

This is not a [Bug] but the very nature of symlinks. If the user needs the linked (as per App::Link I guess) file to open correctly he has to symlink the linked file into the same folder.

This issue should be closed

[leoheck]

No, this is a bug. When you symlink a file, and since Freecad does not adjust paths internally, Freecad should open the target instead. This behavior would solve anything.

[luzpaz]

@FlachyJoe care to weigh-in ?

[luzpaz]

CC @FlachyJoe

[FlachyJoe]

@luzpaz this issue is about App::Links in a symlinked file. I can't see relation with save problem in junction.
Also, I have no knowledge about App::Link, so I can't do anything for this problem.

[luzpaz]

@leoheck just out of curiousity, does realthunder's branch address this issue ?

[leoheck]

Sorry @luzpaz I have never used this branch. Unfortunately, I can't answer this.

[luzpaz]

@realthunder do you have a moment to weigh-in on this ? (specifically since you were involved with App::Link code)

[adrianinsaval]

I tend to agree with zolko that this does not seem like a bug.

[luzpaz]

Anyone able to test realthunder's PR ?

[adrianinsaval]

others also share the view that is no real bug but normal behavior with symlinks:
#11037 (comment)
#11037 (comment)